Skip to content

feature: add secret comment support to overview page#5319

Merged
scott-ray-wilson merged 7 commits intomainfrom
SECRETS-77
Jan 31, 2026
Merged

feature: add secret comment support to overview page#5319
scott-ray-wilson merged 7 commits intomainfrom
SECRETS-77

Conversation

@scott-ray-wilson
Copy link
Contributor

@scott-ray-wilson scott-ray-wilson commented Jan 30, 2026

Context

This PR adds support for adding, editing and viewing comments from the overview dashboard.

Also includes styling, transition and state improvements to secret actions in general

Screenshots

CleanShot 2026-01-29 at 16 41 26@2x

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@maidul98
Copy link
Collaborator

maidul98 commented Jan 30, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@scott-ray-wilson scott-ray-wilson changed the title feat(frontend): Add secret comment support to overview page feature(frontend): Add secret comment support to overview page Jan 30, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 30, 2026

Greptile Overview

Greptile Summary

This PR adds secret comment support to the overview dashboard, allowing users to add, edit, and view comments on secrets.

Key Changes:

  • New SecretCommentForm component for managing secret comments
  • Integrated comment button in secret actions with MessageSquareIcon
  • Added secretComment parameter to secret update flows
  • Improved action button transitions with shouldStayExpanded logic
  • Added thin-scrollbar styling to TextArea component

Issues Found:

  • Permission check uses ProjectPermissionActions.Delete instead of ProjectPermissionActions.Edit for editing comments (SecretCommentForm.tsx:101)

Confidence Score: 4/5

  • safe to merge after fixing the permission check issue
  • the feature is well-implemented with proper UI integration and state management, but has one permission logic bug that should be corrected
  • SecretCommentForm.tsx requires attention for the permission check fix

Important Files Changed

Filename Overview
frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretCommentForm.tsx added new secret comment form component with permission issue on edit button
frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretEditTableRow.tsx integrated comment form with improved action button styling and transitions
frontend/src/pages/secret-manager/OverviewPage/OverviewPage.tsx added optional secretComment parameter to secret update handler
frontend/src/components/v3/generic/TextArea/TextArea.tsx added thin-scrollbar styling class to textarea component
frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretTableRow.tsx passed comment prop from secret to SecretEditTableRow component

greptile-apps[bot]
greptile-apps bot reviewed Jan 30, 2026
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@scott-ray-wilson scott-ray-wilson changed the title feature(frontend): Add secret comment support to overview page feature: Add secret comment support to overview page Jan 30, 2026
@scott-ray-wilson scott-ray-wilson changed the title feature: Add secret comment support to overview page feature: add secret comment support to overview page Jan 30, 2026
victorvhs017
victorvhs017 requested changes Jan 30, 2026
View reviewed changes
victorvhs017
victorvhs017 previously approved these changes Jan 30, 2026
View reviewed changes
Copy link
Contributor

@victorvhs017 victorvhs017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are looking good!

@scott-ray-wilson scott-ray-wilson merged commit 05b99a3 into main Jan 31, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victorvhs017 victorvhs017 victorvhs017 approved these changes

+1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scott-ray-wilson @maidul98 @victorvhs017