Skip to content

improvement: use placeholder color for empty value on secret input#5317

Merged
scott-ray-wilson merged 1 commit intomainfrom
secret-input-empty-value-styling
Jan 29, 2026
Merged

improvement: use placeholder color for empty value on secret input#5317
scott-ray-wilson merged 1 commit intomainfrom
secret-input-empty-value-styling

Conversation

@scott-ray-wilson
Copy link
Contributor

Context

This PR updates the EMPTY placeholder display on the secret input component to use a muted color

Screenshots

CleanShot 2026-01-29 at 13 11 24@2x

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@scott-ray-wilson scott-ray-wilson changed the title style: use placeholder color for empty value on secret input improvement: use placeholder color for empty value on secret input Jan 29, 2026
@maidul98
Copy link
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 29, 2026

Greptile Overview

Greptile Summary

This PR simplifies the styling of empty secret values in the SecretInput component by replacing the conditional text-gray-500/50 class with the standard text-muted utility class used throughout the codebase.

Key changes:

  • Removed the placeholder && condition from the muted styling logic
  • Replaced custom color text-gray-500/50 with standard text-muted utility
  • Now applies muted styling to all empty values, not just when a placeholder is present

Potential concern:
The logic change removes the placeholder check, meaning muted styling now applies to empty values regardless of whether a placeholder is set. This may be intentional for consistency, but should be verified against the expected behavior shown in the screenshot.

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - it's a simple styling improvement
  • Score reflects a straightforward styling change using a standard utility class. The only concern is a subtle logic change (removed placeholder check) that should be verified but is unlikely to cause issues.
  • No files require special attention

Important Files Changed

Filename Overview
frontend/src/components/v2/SecretInput/SecretInput.tsx Simplified empty value styling by replacing conditional text-gray-500/50 with standard text-muted utility

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@IgorHorta IgorHorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

LGTM

@scott-ray-wilson scott-ray-wilson merged commit 5090149 into main Jan 29, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants