chore: add basic constraints deduction for sign certificate#5313
Merged
carlosmonastyrski merged 4 commits intomainfrom Jan 29, 2026
Merged
chore: add basic constraints deduction for sign certificate#5313carlosmonastyrski merged 4 commits intomainfrom
carlosmonastyrski merged 4 commits intomainfrom
Conversation
Contributor
Greptile OverviewGreptile SummaryEnhanced certificate signing to automatically deduce CA status when
Confidence Score: 3/5
Important Files Changed
|
Contributor
Additional Comments (1)
|
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
carlosmonastyrski
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR ensures that when certKeySign is requested then isCA basic constraints is treated as true. This is needed because some clients like cert-manager do not pass in basic constraints extension in the CSR
Screenshots
Steps to verify the change
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).