Skip to content

improvement(pki): add error tooltip for failed cert requests and restrict actions to issued certificates#5283

Merged
saifsmailbox98 merged 2 commits intomainfrom
saif/pki-104-display-certificate-issuance-error-message-in-certificate
Jan 27, 2026
Merged

improvement(pki): add error tooltip for failed cert requests and restrict actions to issued certificates#5283
saifsmailbox98 merged 2 commits intomainfrom
saif/pki-104-display-certificate-issuance-error-message-in-certificate

Conversation

@saifsmailbox98
Copy link
Contributor

@saifsmailbox98 saifsmailbox98 commented Jan 27, 2026

Context

Earlier we only showed the status as Failed in the certificate request page, now there will be a tooltip through which the error message/reason of failure can be checked.

Apart from this, the dropdown menu/options will only be available to the rows having status as Issued.

Screenshots

image

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

…ditionally render dropdown for issued requests.
@saifsmailbox98 saifsmailbox98 changed the title improve(pki): add error tooltip and restrict actions to issued certificates improvement(pki): add error tooltip and restrict actions to issued certificates Jan 27, 2026
@saifsmailbox98 saifsmailbox98 changed the title improvement(pki): add error tooltip and restrict actions to issued certificates improvement(pki): add error tooltip for failed cert requests and restrict actions to issued certificates Jan 27, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 27, 2026

Greptile Overview

Greptile Summary

This PR improves the UX for certificate request management by displaying error details in a tooltip for failed certificate requests and restricting dropdown actions to only issued certificates.

Key Changes:

  • Added errorMessage parameter to the getStatusBadge function to pass error details through
  • Wrapped Failed/Rejected status badges in a Tooltip component that displays the error message (or a default message if none exists)
  • Changed dropdown menu rendering from always showing (with disabled state) to conditionally rendering only for issued certificates with a valid certificateId
  • Removed the disabled prop from the dropdown menu item since it now only renders when the certificate is issued

The changes are well-implemented with proper TypeScript types and improve the user experience by providing better visibility into why certificate requests fail.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - it's a straightforward UI improvement with no security concerns
  • The changes are limited to a single frontend component with clear intent: improving error visibility and hiding irrelevant actions. The implementation properly handles null/undefined cases with TypeScript's optional chaining, the types align with the existing data structure, and there are no security, performance, or breaking change concerns.
  • No files require special attention

Important Files Changed

Filename Overview
frontend/src/pages/cert-manager/CertificateRequestsPage/components/CertificateRequestRow.tsx Added error tooltip for failed certificates and restricted dropdown to issued certificates only - clean implementation with proper TypeScript types

@maidul98
Copy link
Collaborator

maidul98 commented Jan 27, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@saifsmailbox98 saifsmailbox98 merged commit 90e9c2b into main Jan 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants