fix(api): ensure commits are linted/formatted before commit by IgorHorta · Pull Request #5282 · Infisical/infisical

IgorHorta · 2026-01-27T14:25:04Z

Context

The pre-commit hook's lint-staged configuration was not working correctly due to two issues:

Incorrect glob pattern: The pattern ./{frontend/backend}/**/* used a slash instead of a comma, which meant it was looking for a literal directory named frontend/backend instead of matching both frontend/ and backend/ directories.
ESLint config mismatch: When eslint --fix ran from the root directory, it couldn't find the correct ESLint configuration files because:
- Frontend uses the new flat config format (eslint.config.js), which requires running from within the frontend directory
- Backend uses the legacy format (.eslintrc.js) which needs to be explicitly specified via --config

Changes made:

Split lint-staged into separate entries for frontend and backend
Frontend: runs ESLint from within the frontend/ directory to properly detect the flat config
Backend: explicitly specifies the config file path with --config backend/.eslintrc.js
Added helpful comments to the pre-commit hook
Fixed typo: "comitting" → "committing"

Screenshots

Steps to verify the change

Stage a file in the frontend/ directory
Run git commit - ESLint should run successfully without "Parsing error: The keyword 'import' is reserved"
Stage a file in the backend/ directory
Run git commit - ESLint should run successfully with the correct backend rules
Stage files in both directories and verify both linters run

Type

Checklist

Title follows the conventional commit format: type(scope): short description
Tested locally
Updated docs (if needed)
Read the contributing guide

maidul98 · 2026-01-27T14:25:45Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

greptile-apps · 2026-01-27T14:30:20Z

Greptile Overview

Greptile Summary

This PR attempts to fix the pre-commit linting by restructuring how ESLint runs for frontend and backend. However, there are critical issues:

Major concerns:

Security vulnerability: The pre-commit hook containing infisical scan git-changes --staged was deleted, removing the automated secrets detection that prevents developers from committing credentials
lint-staged configuration broken: The bash parameter expansion pattern ${@#frontend/} and ${@#backend/} won't correctly strip the ./ prefix from paths that lint-staged passes (e.g., ./frontend/src/App.tsx), causing ESLint to receive incorrect file paths
Verification steps don't match implementation: The PR description claims lint-staged runs on commit, but the pre-commit hook was deleted - linting only happens at push time now

Changes made:

Deleted .husky/pre-commit hook (removed lint-staged and infisical scan)
Added new .husky/pre-push hook with manual linting logic
Split lint-staged config into separate frontend/backend entries with cd commands
Added --max-warnings 0 flag to all lint scripts
Fixed eslint-disable comments in backend files to be more specific

Recommendations:

Restore the infisical scan in a git hook (either pre-commit or pre-push)
Fix the parameter expansion in lint-staged to handle ./ prefixed paths correctly
Test that lint-staged actually works with the current configuration

Confidence Score: 1/5

This PR has critical security and functionality issues that must be addressed before merging
Score reflects the removal of security scanning (infisical scan) and broken lint-staged configuration with incorrect parameter expansion that won't work as intended
.husky/pre-commit (deleted - needs to be restored with security scan), package.json (lint-staged config has broken path handling)

Important Files Changed

Filename	Overview
.husky/pre-commit	Deleted pre-commit hook that ran lint-staged and infisical scan
.husky/pre-push	Added new pre-push hook with manual linting logic for frontend and backend
package.json	Fixed lint-staged configuration to run ESLint correctly for frontend and backend

greptile-apps

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

package.json

victorvhs017 · 2026-01-27T22:11:54Z

@greptileai re-review and update the summary

scott-ray-wilson

Works well overall! two comments

backend/src/db/auditlog-knexfile.ts

package.json

IgorHorta · 2026-01-28T14:24:41Z

@greptileai re-review and update the summary re-review and update the summary

greptile-apps

_{3 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

package.json

greptile-apps · 2026-01-28T14:29:52Z

Additional Comments (2)

.husky/pre-commit
Deleting pre-commit hook removes critical security scan (infisical scan git-changes --staged) that prevents committing secrets. This creates a major vulnerability - developers can now commit credentials without detection.

.husky/pre-commit
lint-staged is no longer running at commit time - only at push time. This means uncommitted linting errors will accumulate, and the PR description's verification steps won't work as described.

scott-ray-wilson

Works great, nice work!

IgorHorta added 4 commits January 27, 2026 10:52

test: evaluating pre-commit hook

3912c43

fix: validate if the package rule is fixed

4a4c84e

fix: test be lint

4232cc8

fix: eslint not running properly at

88bd0ed

IgorHorta changed the title ~~fix:(api) ensure commits are linted/formatted before commit~~ fix(api): ensure commits are linted/formatted before commit Jan 27, 2026

greptile-apps bot reviewed Jan 27, 2026

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

addressing comments from greptile

aef9d03

IgorHorta assigned victorvhs017 Jan 27, 2026

fix: lint issues

933fbb5

victorvhs017 previously approved these changes Jan 27, 2026

View reviewed changes

scott-ray-wilson requested changes Jan 28, 2026

View reviewed changes

backend/src/db/auditlog-knexfile.ts Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

IgorHorta dismissed victorvhs017’s stale review via 75f5ddc January 28, 2026 13:26

IgorHorta force-pushed the igor/eng-4151-ensure-commits-are-lintedformatted-before-commit branch from a2fe36f to 933fbb5 Compare January 28, 2026 13:39

IgorHorta added 8 commits January 28, 2026 10:40

fix: remove unecessary comment

7e5f2bb

fix: adding as prepush

23fa3e2

fix: prepush

bcb3a14

fix: testing prepush

a33ae8f

fix: reverting files touched to test prepush

21978fb

fix: reverting files that were add to test prepush

f6e3fc8

chore: remove unused lint-changed.sh script

76fb3b1

reverting unecessary change

1683ccf

IgorHorta requested a review from scott-ray-wilson January 28, 2026 14:24

IgorHorta requested a review from victorvhs017 January 28, 2026 14:25

greptile-apps bot reviewed Jan 28, 2026

View reviewed changes

package.json Show resolved Hide resolved

package.json Show resolved Hide resolved

fix: revert back to pre-commit

a252b1d

scott-ray-wilson approved these changes Jan 28, 2026

View reviewed changes

IgorHorta merged commit af5f1d9 into main Jan 28, 2026
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(api): ensure commits are linted/formatted before commit#5282

fix(api): ensure commits are linted/formatted before commit#5282
IgorHorta merged 15 commits intomainfrom
igor/eng-4151-ensure-commits-are-lintedformatted-before-commit

IgorHorta commented Jan 27, 2026 •

edited

Loading

Uh oh!

maidul98 commented Jan 27, 2026 •

edited

Loading

Uh oh!

greptile-apps bot commented Jan 27, 2026 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

victorvhs017 commented Jan 27, 2026

Uh oh!

scott-ray-wilson left a comment

Uh oh!

Uh oh!

Uh oh!

IgorHorta commented Jan 28, 2026 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot commented Jan 28, 2026

Uh oh!

scott-ray-wilson left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

IgorHorta commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Changes made:

Screenshots

Steps to verify the change

Type

Checklist

Uh oh!

maidul98 commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

greptile-apps bot commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Confidence Score: 1/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

victorvhs017 commented Jan 27, 2026

Uh oh!

scott-ray-wilson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

IgorHorta commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot commented Jan 28, 2026

Uh oh!

scott-ray-wilson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

IgorHorta commented Jan 27, 2026 •

edited

Loading

maidul98 commented Jan 27, 2026 •

edited

Loading

greptile-apps bot commented Jan 27, 2026 •

edited

Loading

IgorHorta commented Jan 28, 2026 •

edited

Loading