Skip to content

fix: remove project version check from grantProjectAdminAccess#5272

Merged
sheensantoscapadngan merged 1 commit intomainfrom
devin/1769436439-remove-project-version-check
Jan 27, 2026
Merged

fix: remove project version check from grantProjectAdminAccess#5272
sheensantoscapadngan merged 1 commit intomainfrom
devin/1769436439-remove-project-version-check

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 26, 2026

Context

Organization admins were unable to access or delete legacy V1/V2 projects through the admin console because grantProjectAdminAccess was blocking access with the error: "Project is a legacy project and must be upgraded before accessing it through the admin console."

This check was originally added to handle encryption key exchange when joining as admin, but that logic has since been removed when encryption keys were stripped off completely. The version check is no longer necessary and was preventing admins from managing legacy projects.

This PR removes the version check, allowing org admins to access all projects regardless of version.

Steps to verify the change

  1. As an org admin, navigate to the admin console
  2. Attempt to access a V1 or V2 legacy project
  3. Verify that access is now granted without the "legacy project" error

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

Link to Devin run
Requested by: @sheensantoscapadngan

@devin-ai-integration @sheensantoscapadngan
fix: remove project version check from grantProjectAdminAccess
5d4ee9d 
Co-Authored-By: sheen@infisical.com <sheensantoscapadngan@gmail.com>
@devin-ai-integration
Copy link
Contributor Author

devin-ai-integration bot commented Jan 26, 2026

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@maidul98
Copy link
Collaborator

maidul98 commented Jan 26, 2026

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 26, 2026

Greptile Overview

Greptile Summary

Removed the legacy project version check (V1/V2) from the grantProjectAdminAccess function that was preventing org admins from accessing or deleting legacy projects through the admin console. The version check was originally added to handle encryption key exchange when granting admin access, but this logic was removed during the SRP (Secure Remote Password) removal in July 2025 when encryption keys were stripped from the system. The check is now obsolete and was blocking legitimate admin operations on legacy projects.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change removes an obsolete version check that was blocking org admins from accessing legacy V1/V2 projects. The original purpose of this check (handling encryption key exchange) was removed in July 2025 during the SRP removal. All necessary access controls remain in place - the function still verifies org admin permissions via OrgPermissionAdminConsoleAction.AccessAllProjects before granting access. The change is a simple cleanup that removes dead code without introducing new functionality or security risks.
  • No files require special attention

Important Files Changed

Filename Overview
backend/src/services/org-admin/org-admin-service.ts Removed legacy V1/V2 project version check from grantProjectAdminAccess, removed unused imports (ProjectVersion, BadRequestError)

@sheensantoscapadngan sheensantoscapadngan merged commit 822c422 into main Jan 27, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheensantoscapadngan sheensantoscapadngan sheensantoscapadngan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maidul98 @sheensantoscapadngan