feat: circle ci secret sync by luizbafilho · Pull Request #5255 · Infisical/infisical

luizbafilho · 2026-01-23T15:52:54Z

Context

Screenshots

Steps to verify the change

Type

Checklist

Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
Tested locally
Updated docs (if needed)
Read the contributing guide

This commit adds comprehensive support for CircleCI as an app connection type, including backend services, routes, frontend forms, and type definitions. CircleCI connections use Personal Access Token authentication method.

Implement full support for CircleCI as a secret sync destination, including: - CircleCI project listing via API connection - Secret syncing to CircleCI environment variables - Backend router endpoints and service layer - Frontend forms, types, and UI components - Integration with existing secret sync framework

maidul98 · 2026-01-23T15:53:27Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

greptile-apps · 2026-01-23T15:57:32Z

Greptile Overview

Greptile Summary

This PR adds CircleCI secret sync functionality to Infisical, allowing users to sync secrets from Infisical to CircleCI project environment variables.

Key Changes:

Implemented CircleCI app connection support with API token authentication
Added secret sync functionality supporting create, update, and delete operations
Created comprehensive documentation for both app connections and secret syncs
Added UI components for configuring CircleCI connections and syncs
Properly handles pagination when listing CircleCI environment variables

Issues Found:

Documentation contains field name inconsistencies in API examples (apiKey vs apiToken, api-key vs api-token)
The unused existingEnvVarNames variable issue mentioned in previous reviews has been fixed in this version

The implementation follows the existing patterns for other secret sync integrations in the codebase, maintaining consistency across the system.

Confidence Score: 4/5

This PR is safe to merge with minor documentation fixes needed
The implementation is solid and follows established patterns. The code quality is good with proper error handling and validation. However, the documentation has syntax errors in API examples that need correction before merge to avoid customer confusion.
docs/integrations/app-connections/circleci.mdx requires corrections to API example field names

Important Files Changed

Filename	Overview
backend/src/services/secret-sync/circleci/circleci-sync-fns.ts	Implements CircleCI secret sync logic with proper error handling and pagination. Fixed unused `existingEnvVarNames` variable issue from previous review.
backend/src/services/app-connection/circleci/circleci-connection-fns.ts	Handles CircleCI connection validation and organization listing. Properly validates API tokens against CircleCI's API.
docs/integrations/app-connections/circleci.mdx	Documentation for CircleCI app connection. Contains inconsistencies in API examples (uses `apiKey` instead of `apiToken`, and `api-key` instead of `api-token`).
backend/src/services/secret-sync/circleci/circleci-sync-schemas.ts	Defines Zod schemas for CircleCI sync configuration. Properly validates required fields for organization, project name, and project ID.
backend/src/services/app-connection/circleci/circleci-connection-schemas.ts	Defines Zod schemas for CircleCI connection credentials. Uses `apiToken` field for API token authentication.

greptile-apps

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

backend/src/services/secret-sync/circleci/circleci-sync-fns.ts

backend/src/services/app-connection/circleci/circleci-connection-fns.ts

…pp-connection

varonix0 · 2026-01-26T20:56:48Z

@greptile re-review this

greptile-apps

_{4 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

backend/src/services/secret-sync/circleci/circleci-sync-fns.ts

varonix0 · 2026-01-26T21:07:08Z

@greptile re-review this with the context of my comments to your comments in mind and update your summary

greptile-apps

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

docs/integrations/app-connections/circleci.mdx

backend/src/services/app-connection/circleci/circleci-connection-fns.ts

backend/src/services/secret-sync/circleci/circleci-sync-fns.ts

backend/src/lib/api-docs/constants.ts

…pp-connection

luizbafilho added 2 commits January 22, 2026 17:45

Add CircleCI app connection support

bf3f614

This commit adds comprehensive support for CircleCI as an app connection type, including backend services, routes, frontend forms, and type definitions. CircleCI connections use Personal Access Token authentication method.

greptile-apps bot reviewed Jan 23, 2026

View reviewed changes

backend/src/services/secret-sync/circleci/circleci-sync-fns.ts Show resolved Hide resolved

backend/src/services/app-connection/circleci/circleci-connection-fns.ts Outdated Show resolved Hide resolved

varonix0 changed the title ~~Add CircleCI app connection support~~ feat: circle ci secret sync Jan 24, 2026

varonix0 added 3 commits January 26, 2026 22:25

Merge branch 'main' into luiz/eng-2937-create-circle-ci-secret-sync-a…

65b670d

…pp-connection

feat: circleci app connection and secret sync

b758c7d

Merge branch 'main' into luiz/eng-2937-create-circle-ci-secret-sync-a…

6757ae0

…pp-connection

greptile-apps bot reviewed Jan 26, 2026

View reviewed changes

varonix0 added 2 commits January 27, 2026 01:02

fix: types

bed2ca7

fix: types

4e0b412

greptile-apps bot reviewed Jan 26, 2026

View reviewed changes

docs/integrations/app-connections/circleci.mdx Outdated Show resolved Hide resolved

docs/integrations/app-connections/circleci.mdx Outdated Show resolved Hide resolved

varonix0 added 2 commits January 27, 2026 01:17

fix: types

96a735b

fix: missing api docs

be09249

carlosmonastyrski requested changes Jan 28, 2026

View reviewed changes

backend/src/services/app-connection/circleci/circleci-connection-fns.ts Outdated Show resolved Hide resolved

backend/src/services/secret-sync/circleci/circleci-sync-fns.ts Outdated Show resolved Hide resolved

backend/src/lib/api-docs/constants.ts Show resolved Hide resolved

varonix0 added 5 commits January 28, 2026 17:07

requested changes

0c30169

nits

739b458

Update circleci.mdx

9614ba8

Merge branch 'main' into luiz/eng-2937-create-circle-ci-secret-sync-a…

d7798a3

…pp-connection

requested changes

5383f43

carlosmonastyrski previously approved these changes Jan 28, 2026

View reviewed changes

fix lint

94e2bb6

varonix0 dismissed carlosmonastyrski’s stale review via 94e2bb6 January 28, 2026 21:54

varonix0 requested a review from carlosmonastyrski January 28, 2026 21:54

varonix0 approved these changes Jan 28, 2026

View reviewed changes

varonix0 merged commit 0783520 into main Jan 28, 2026
12 of 13 checks passed

Conversation

luizbafilho commented Jan 23, 2026

Context

Screenshots

Steps to verify the change

Type

Checklist

Uh oh!

maidul98 commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

greptile-apps bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

varonix0 commented Jan 26, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

varonix0 commented Jan 26, 2026

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

maidul98 commented Jan 23, 2026 •

edited

Loading

greptile-apps bot commented Jan 23, 2026 •

edited

Loading