fix: migration error in read-compat-flag#5232
Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
maidul98
approved these changes
Jan 22, 2026
Contributor
Greptile SummaryFixed a bug in the migration's raw SQL query where parameter binding was incorrect. The raw query template expected individual placeholders for each ID in the IN clause, but was receiving the entire array as a single parameter. Switched to knex query builder which handles array parameters correctly for
Confidence Score: 4/5
Important Files Changed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes an error in raw query where the array was treated as parameterized items (so if there were more items in the array it would be greater than the expected params count). Switched it back to normal query instead of raw. This was converted to raw query to avoid ts error that happened due to later removing this field. Suppressed with with ts-expect-error command.
Screenshots
Steps to verify the change
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).