Skip to content

chore: add CA:true policy constraint to docs#5231

Merged
carlosmonastyrski merged 3 commits intomainfrom
docs/PKI-99
Jan 23, 2026
Merged

chore: add CA:true policy constraint to docs#5231
carlosmonastyrski merged 3 commits intomainfrom
docs/PKI-99

Conversation

@carlosmonastyrski
Copy link
Contributor

@carlosmonastyrski carlosmonastyrski commented Jan 22, 2026

Context

Add the missing new fields of certificate policies for basic constraints on the docs for policies and k8s cert-manager

Screenshots

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@maidul98
Copy link
Collaborator

maidul98 commented Jan 22, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 22, 2026

Greptile Summary

Added documentation for Basic Constraints policy fields in certificate policies and k8s cert-manager integration.

Key changes:

  • Added "Basic Constraints" section explaining CA certificate property options (Forbid, Allow, Require) and Maximum Allowed Path Length configuration
  • Added isCA: false field to k8s cert-manager Certificate YAML example
  • Added important note about cert-manager's lack of pathLen support, warning users to avoid setting path length restrictions when issuing CA certificates

Issue found:

  • Minor grammar error: "only allow to issue" should be "only allows to issue" in the Require option description

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - it only adds documentation
  • Documentation-only change that adds clear, helpful guidance for certificate policy Basic Constraints configuration. The only issue is a minor grammar error that doesn't affect functionality
  • No files require special attention

Important Files Changed

Filename Overview
docs/documentation/platform/pki/certificates/policies.mdx Added comprehensive documentation for Basic Constraints field including CA certificate property and path length options
docs/documentation/platform/pki/k8s-cert-manager.mdx Added isCA field to example YAML and important note about pathLen limitation in cert-manager

greptile-apps[bot]
greptile-apps bot reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

dangtony98
dangtony98 requested changes Jan 22, 2026
View reviewed changes
@carlosmonastyrski carlosmonastyrski merged commit 944c37a into main Jan 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dangtony98 dangtony98 dangtony98 approved these changes

+1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlosmonastyrski @maidul98 @dangtony98