Skip to content

improvement(gitlab-integration): moved from 'name' to 'fullName' when using GitLab groups#5229

Merged
victorvhs017 merged 1 commit intomainfrom
improvement/use-fullname-in-git-lab-groups
Jan 22, 2026
Merged

improvement(gitlab-integration): moved from 'name' to 'fullName' when using GitLab groups#5229
victorvhs017 merged 1 commit intomainfrom
improvement/use-fullname-in-git-lab-groups

Conversation

@victorvhs017
Copy link
Contributor

@victorvhs017 victorvhs017 commented Jan 21, 2026

Context

We are now using the fullName instead of the name property for GitLab groups to show the full path for subgroups.

Screenshots

image image

Steps to verify the change

Add subgroups to your GitLab account and test the integration in the secret sync and secret scanning features.

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@maidul98
Copy link
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 21, 2026

Greptile Summary

This PR improves GitLab group selection UX by displaying the full path for subgroups instead of just the group name. The change updates both backend and frontend to use fullName (e.g., "parent/child/subgroup") instead of name (e.g., "subgroup").

Key changes:

  • Updated API response schema and types to return fullName instead of name
  • Frontend now displays full group paths in dropdown selectors for both secret scanning and secret syncs
  • Fixed getOptionValue in GitLabDataSourceConfigFields.tsx to use option.id instead of option.name for proper unique identification

The change is backward compatible - existing saved configurations with the short name will continue to display correctly, while new configurations will show the full hierarchical path.

Confidence Score: 5/5

  • This PR is safe to merge with no identified risks
  • The changes are straightforward and well-implemented: a simple property rename from name to fullName across the stack. The implementation is consistent across backend types, API responses, and frontend components. The change is backward compatible since stored groupName values are only used for display purposes. The fix to use option.id for getOptionValue actually improves uniqueness guarantees.
  • No files require special attention

Important Files Changed

Filename Overview
backend/src/services/app-connection/gitlab/gitlab-connection-fns.ts Changed returned property from name to fullName to show full group path including parent groups
frontend/src/components/secret-scanning/forms/SecretScanningDataSourceConfigFields/GitLabDataSourceConfigFields.tsx Updated group selection to use fullName for display and id for value instead of name
frontend/src/components/secret-syncs/forms/SecretSyncDestinationFields/GitLabSyncFields.tsx Updated group selection to display fullName instead of name

Copy link
Contributor

@scott-ray-wilson scott-ray-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, verified both sync and data source display

@victorvhs017 victorvhs017 merged commit a5278d2 into main Jan 22, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants