Skip to content

improvement(secret-syncs): update max name size to 256#5215

Merged
x032205 merged 3 commits intomainfrom
increase-secret-sync-name-max-length
Jan 22, 2026
Merged

improvement(secret-syncs): update max name size to 256#5215
x032205 merged 3 commits intomainfrom
increase-secret-sync-name-max-length

Conversation

@x032205
Copy link
Member

@x032205 x032205 commented Jan 20, 2026

Context

Update max sync name size to 256

Screenshots

CleanShot 2026-01-20 at 12 59 29@2x

Steps to verify the change

Create & update syncs with long names.

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@maidul98
Copy link
Collaborator

maidul98 commented Jan 20, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 20, 2026

Greptile Summary

This PR increases the maximum length for secret sync names from 32 to 256 characters. The change is consistently applied across the database schema (via migration), backend validation schemas, and frontend validation schemas. The migration safely alters the existing column without affecting the unique constraint on [projectId, name]. All validation logic correctly uses the slugSchema helper with the new max: 256 parameter.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is straightforward and well-implemented. The migration safely expands the column size (no data loss risk), all validation schemas are updated consistently across frontend and backend, and the unique constraint on [projectId, name] is preserved. The change is backward compatible since existing names under 32 characters will continue to work.
  • No files require special attention

Important Files Changed

Filename Overview
backend/src/db/migrations/20260120175003_increase-secret-sync-name-size.ts Increases name column size from 32 to 256 characters in SecretSync table
backend/src/services/secret-sync/secret-sync-schemas.ts Updates validation schemas to allow up to 256 characters for sync names
frontend/src/components/secret-syncs/forms/schemas/base-secret-sync-schema.ts Updates frontend validation to match backend 256 character limit

@x032205 x032205 requested review from carlosmonastyrski and removed request for scott-ray-wilson January 20, 2026 18:06
@x032205 x032205 merged commit e5e6942 into main Jan 22, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosmonastyrski carlosmonastyrski carlosmonastyrski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@x032205 @maidul98 @carlosmonastyrski