Skip to content

fix: streamline APKINDEX generation and signing process#126

Merged
victorvhs017 merged 1 commit intomainfrom
fix/apk-signing
Feb 12, 2026
Merged

fix: streamline APKINDEX generation and signing process#126
victorvhs017 merged 1 commit intomainfrom
fix/apk-signing

Conversation

@victorvhs017
Copy link
Contributor

Description 📣

  • Generate and sign APKINDEX.tar.gz using Alpine container with abuild-sign
  • Use --allow-untrusted for index generation (matches Cloudsmith behavior - only index is signed, not individual packages)

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

- Introduced a function to handle the generation and signing of APKINDEX for different architectures, improving code reusability and clarity.
- Updated comments to clarify the signing process for nFPM-generated APKs and the use of --allow-untrusted flag.
@victorvhs017 victorvhs017 changed the title refactor: streamline APKINDEX generation and signing process fix: streamline APKINDEX generation and signing process Feb 11, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 11, 2026

Greptile Overview

Greptile Summary

This PR refactors the APKINDEX generation process to use a cleaner, more maintainable approach. The key changes include:

  • Extracted duplicate APKINDEX generation code for x86_64 and aarch64 into a reusable process_arch() function
  • Added --allow-untrusted flag to apk index command to support nFPM-generated packages that aren't individually signed with Alpine tools
  • Improved documentation explaining that only the APKINDEX is signed (containing package checksums), not individual APK files, which matches Cloudsmith's behavior

The refactoring improves code maintainability by eliminating duplication and makes the architecture handling more scalable.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are a straightforward refactoring that improves code organization without altering core functionality. The addition of --allow-untrusted properly addresses the nFPM package signing model, and the function extraction reduces code duplication while maintaining the same behavior. No security concerns or breaking changes were identified.
  • No files require special attention

Important Files Changed

Filename Overview
upload_to_cloudsmith.sh Refactored APKINDEX generation into a reusable function and added --allow-untrusted flag for nFPM-generated packages. Improved code organization with clear documentation.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@victorvhs017 victorvhs017 merged commit 825440c into main Feb 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants