Conversation
When users pass --domain flag (e.g., --domain https://eu.infisical.com), the CLI should use that domain directly without prompting for hosting selection. Previously, the hosting selection prompt would still appear even when --domain was explicitly provided with EU/US cloud URLs. This fix checks if the --domain flag was explicitly changed by the user and if so, uses that domain directly without prompting. Co-Authored-By: Vlad Matsiiako <vm265@cornell.edu>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Greptile OverviewGreptile SummaryThis PR fixes a bug where the CLI would prompt users to select a hosting option even when the Key changes:
How it works:
The fix properly handles the edge case where cloud URLs should be used when explicitly specified but not added to the persistent config file. Confidence Score: 5/5
Important Files Changed
|
akhilmhdh
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
Fixes an issue where running
infisical login --domain "https://eu.infisical.com"still prompts the user to select a hosting option, even though the domain was explicitly specified via the flag.Problem: When using
--domainwith EU/US cloud URLs, the CLI would still show the interactive hosting selection prompt:This made it impossible to script the login flow (e.g., for terraform plan) without human input.
Solution: Check if the
--domainflag was explicitly set by the user. If so, use that domain directly without prompting, even for US/EU cloud URLs.Type ✨
Tests 🛠️
Manual verification:
infisical login --domain "https://eu.infisical.com"should skip the hosting selection promptinfisical login(without --domain) should still show the hosting selection prompt as beforeKey areas for review:
shouldUsePresetDomainconditionLink to Devin run: https://app.devin.ai/sessions/f8e999bcf9bd49f5912415d268f52bce
Requested by: Vlad Matsiiako (@vmatsiiako)