Skip to content

[src] Add new methods to internally handle SOFA (right handed) into Unity (left handed) coordinate system#156

Merged
epernod merged 7 commits intomainfrom
fix_negativeX
Mar 31, 2025
Merged

[src] Add new methods to internally handle SOFA (right handed) into Unity (left handed) coordinate system#156
epernod merged 7 commits intomainfrom
fix_negativeX

Conversation

@epernod
Copy link
Copy Markdown
Contributor

@epernod epernod commented Mar 28, 2025 •
edited
Loading

  • All methods inside the xxxMeshAPI class are doing the conversion.
  • All methods get Unity mesh.vertices or Vector3 GetPosition returns coordinates in left handed system.
  • Add gettter to avoid using raw buffers coming from SOFA
  • Update all topology code to draw Triangle, Tetrahedron and Hexahedron in the correct order
  • Handle NO_TOPOLOGY case
  • Fix tricky cases for particles without mesh or beamModel with edge topology or 1D for heat diffusion

@epernod epernod added pr: clean pr: status to review To notify reviewers to review this pull-request labels Mar 28, 2025
epernod
epernod commented Mar 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@epernod epernod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert some unwanted changes

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 31, 2025
@epernod epernod merged commit c21930d into main Mar 31, 2025
@epernod epernod deleted the fix_negativeX branch March 31, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: clean pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@epernod