Skip to content

Conversation

@yehoshuapw
Copy link
Contributor

Added lv_font_conv based command to src/displayapp/fonts/README.md.

@Riksu9000
Copy link
Contributor

I think we should only support one method to keep the instructions as simple as possible. The fonts may some day be automatically generated with lv_font_conv, but for now I would keep the instructions as they are.

@yehoshuapw
Copy link
Contributor Author

In that case, everything in the file should probably be changed to one method, maybe with a reference at the end that it can also be done using command line.

Also, about auto-generating: I think that some config file (a file json for example) should include all the generated fonts,
and a build_font script be created. if this is an accepted method, I can do it. any better ideas? (parsing the relevant info from the README is doable, but untrustworthy)

@Riksu9000
Copy link
Contributor

Riksu9000 commented Apr 18, 2022

Yeah, I agree. The font readme was recently updated, but there's a mistake where it says the offline converter is required, when it actually isn't and I've been meaning to fix it.

Auto generating is definitely something we would like to have. I can't really comment on what the best method would be, or if it should be integrated with CMake somehow. No need to parse the readme at least. The readme won't be needed after auto generation has been implemented. (Apart from info about icomoon I suppose)

@yehoshuapw yehoshuapw mentioned this pull request Apr 18, 2022
@JF002 JF002 closed this in #1097 May 10, 2022
@yehoshuapw yehoshuapw deleted the add-font-gen-commandline branch May 10, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants