Skip to content

Conversation

@coxtor
Copy link
Contributor

@coxtor coxtor commented Oct 3, 2021

This PR adds the option to configure the action of the pushbutton (back or watchface
PXL_20211003_185333721
).

@Riksu9000
Copy link
Contributor

#480 already implements this without needing the option. Tap for back and long press 400ms for watchface.

@coxtor
Copy link
Contributor Author

coxtor commented Oct 3, 2021

The button handler is nice, however the user should still have the option to decide what happens when the button is actually pushed. In my opinion these prs implement different functions and do not exclude themselves, or am I missing something?

@Riksu9000
Copy link
Contributor

The button handler is nice, however the user should still have the option to decide what happens when the button is actually pushed. In my opinion these prs implement different functions and do not exclude themselves, or am I missing something?

As I said, in #480 long pressing the button goes to the watch face, while a short press still goes back a single step. There's no reason to choose only one action, when you can have both at the same time, right?

@hubmartin
Copy link
Contributor

I agree with @Riksu9000. I use #480 for a long time and it has both options all solved by a single button and no config (plus doubleclick app and loooong press app). His PR also solves lot of other issues we have with debouncing, fast wake up etc.
When the #480 will be merged, then this configuration will not make a sense, otherwise short click will go to watchface and longer press will also go to watchface.

@coxtor
Copy link
Contributor Author

coxtor commented Oct 3, 2021

I see, under those circumstances we can consider this pr obsolete :) .

@coxtor coxtor closed this Oct 3, 2021
@hubmartin
Copy link
Contributor

@coxtor Sorry for that. I've been threre too. There's a lot of pull requests and lot of them are tangled together or "hidden" on the second page. However JF002 is working really hard to merge them together so it will be less cluttered. On the other side, more people are contributing which is also great :) Thanks for your contribution anyway. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants