Skip to content

Replace app_timer with FreeRTOS timers in TimerController #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Riksu9000 merged 1 commit into from
Apr 25, 2022
Merged

Replace app_timer with FreeRTOS timers in TimerController #494

Riksu9000 merged 1 commit into from
Apr 25, 2022

Conversation

@Riksu9000
Copy link
Contributor

@Riksu9000 Riksu9000 commented Jul 17, 2021 •
edited
Loading

I read that this would be preferred, as app_timer is an nrf specific feature.

@Riksu9000
Copy link
Contributor Author

Riksu9000 commented Aug 19, 2021

After #544, converting MotorController to use FreeRTOS Timers would require more work, so I removed the changes for now. For now only TimerController is converted.

@Riksu9000 Riksu9000 changed the title Replace app_timer with FreeRTOS timers Replace app_timer with FreeRTOS timers in TimerController Aug 19, 2021
@JF002 JF002 mentioned this pull request Sep 18, 2021
Merged
@mjnck mjnck mentioned this pull request Sep 19, 2021
Merged
@Riksu9000
Copy link
Contributor Author

Riksu9000 commented Mar 25, 2022

@NeroBurner The simulator doesn't have these two functions xTimerGetExpiryTime() and xTimerIsTimerActive(). If this ever gets merged, they will need to be added.

@NeroBurner NeroBurner mentioned this pull request Mar 29, 2022
Closed
@NeroBurner
Copy link
Contributor

NeroBurner commented Mar 29, 2022

@Riksu9000 thanks for the notification, please try with the current main branch of the simulator (commit InfiniTimeOrg/InfiniSim@3cc6e74) where InfiniTimeOrg/InfiniSim#17 is fixed and the two missing functions implemented

@Avamander Avamander added this to the 1.10.0 milestone Apr 18, 2022
JF002
JF002 reviewed Apr 24, 2022
View reviewed changes
@Riksu9000 Riksu9000 merged commit b7b1af1 into InfiniTimeOrg:develop Apr 25, 2022
@Riksu9000 Riksu9000 deleted the remove_app_timer branch April 25, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JF002 JF002 JF002 approved these changes

@NeroBurner NeroBurner NeroBurner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Riksu9000 @NeroBurner @JF002 @Avamander