-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Using littlefs #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using littlefs #438
Conversation
|
Size that this adds? |
Worth it. :D |
|
Thanks @joaquimorg ! That's one PR I was waiting for :) I'll have to delay my review a bit because I need to work on adding the support for the replacement motion sensor, but i'll revew it asap! |
|
During compile I got this error: /home/mysteriouslog6/InfiniTime2/src/libs/littlefs/lfs.c:429:13: warning: 'lfs_mlist_isopen' defined but not used [-Wunused-function] |
I have the same warning. It's not a big deal, as it's just a method that is defined but not used. This warning is generated by a source file from littlefs, so I think we can ignore it. But it would be nice if we could find a way to prevent this warning from happening using some cmake trickery, for example. Is it possible to disable specific warning on specific target/lib ? |
JF002
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this great PR @joaquimorg ! This integration of a FS in InfiniTime will allow to add a lot of useful feature by freeing some space in the internal memory and by using this huuuuuge SPI memory!
The code is really good, I only have a few minor comments/questions you'll find in this review :)
|
Thanks for this PR @joaquimorg ! |
This PR adds support for littlefs.