Skip to content

Conversation

@joaquimorg
Copy link
Contributor

This PR adds support for littlefs.

  • New submodule littlefs
  • Functions to read and write files in external flash
  • Settings are now saved to a file in external flash
  • Functions for LVGL to read from external flash

@joaquimorg joaquimorg mentioned this pull request Jun 17, 2021
6 tasks
@ObiKeahloa
Copy link
Contributor

Size that this adds?

@Avamander
Copy link
Collaborator

Size that this adds?

Worth it. :D

@JF002
Copy link
Collaborator

JF002 commented Jun 18, 2021

Thanks @joaquimorg ! That's one PR I was waiting for :)

I'll have to delay my review a bit because I need to work on adding the support for the replacement motion sensor, but i'll revew it asap!

@ObiKeahloa
Copy link
Contributor

During compile I got this error:

/home/mysteriouslog6/InfiniTime2/src/libs/littlefs/lfs.c:429:13: warning: 'lfs_mlist_isopen' defined but not used [-Wunused-function]
429 | static bool lfs_mlist_isopen(struct lfs_mlist *head,

@JF002 JF002 added this to the Version 1.3 milestone Jun 29, 2021
@JF002
Copy link
Collaborator

JF002 commented Jun 29, 2021

During compile I got this error:

/home/mysteriouslog6/InfiniTime2/src/libs/littlefs/lfs.c:429:13: warning: 'lfs_mlist_isopen' defined but not used [-Wunused-function]
429 | static bool lfs_mlist_isopen(struct lfs_mlist *head,

I have the same warning. It's not a big deal, as it's just a method that is defined but not used. This warning is generated by a source file from littlefs, so I think we can ignore it. But it would be nice if we could find a way to prevent this warning from happening using some cmake trickery, for example. Is it possible to disable specific warning on specific target/lib ?

Copy link
Collaborator

@JF002 JF002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great PR @joaquimorg ! This integration of a FS in InfiniTime will allow to add a lot of useful feature by freeing some space in the internal memory and by using this huuuuuge SPI memory!

The code is really good, I only have a few minor comments/questions you'll find in this review :)

@JF002
Copy link
Collaborator

JF002 commented Jul 11, 2021

Thanks for this PR @joaquimorg !

@JF002 JF002 merged commit 084123b into InfiniTimeOrg:develop Jul 11, 2021
This was referenced Jul 13, 2021
@JF002 JF002 mentioned this pull request Aug 2, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants