-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update UI to make better use of the small screen #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Any chance for comparison images? :D |
|
I like this, mainly because it takes me at me at least 3 tries to hit the validate firmware button each time. Would it be possible to standardise the theme/button colours between quick settings and main menu in this PR too? |
I'm not totally sure what you meant, but because of the vibration button, I don't think the base color can be turqoise in quick settings. However, when vibration is enabled, the button could be turqoise, and now we would have a standard accent color. I'll test this and post a pic soon. |
|
Maybe the selected (vibration) button could have an outline/border instead of being a different colour, but what I meant was to have the quick settings menu look the same as the main menu in terms of the button background colour being turquoise/teal/whatever it is. It's not very important, and would maybe be better as a separate PR, since it doesn't align well with the goals of this PR. In any case, nice work. |
|
I personally think the buttons should still be kept gray so that the enabled state really contrasts with the disabled state. And gray buttons are still used in the settings menus with the checkboxes, so it's not totally inconsistent. So maybe we shouldn't change that now. Here is the pic anyway. Maybe in the future the accent color will be selectable and this is how it would look then. Also should the firmware validation buttons be made wider like in the UI guidelines I wrote, or would there be worry that the user might accidentally press the wrong one? These changes aren't committed. |
|
I would recommend making a little space between the Validate and Reset buttons I have clicked on "Find My Device" on my mi band accidentally a few times due to there being very little space. A little bit of space is good so that even if you click a bit off-center you don't click the other button. |
|
Similar to the one in commit already. |
I like the wider buttons on the firmware validator, but I think the quick settings changes should be in a separate PR. |
|
Works and looks fine on my P8. Exactly what I did a week ago in Music Player screen. I hated small buttons that don't go to the edge of the display. Thanks |
|
I just tested this branch with the update_settings branch #442, they work well together and make it much easier to interact with. Nice work. |
|
These changes look good! |
I like what @Riksu9000 does to improve the overall look. As for #442, I think replacing checkboxes with buttons doesn't make much sense, we've lost track of whether it's a selection or if it's a button. |
Would this be better? I simply made them square so they're just a bit smaller
I get your point. The reason I wanted to change it is mainly to expose the border, so it's easier to press. Also the display timeout screen would be hard to make work like in #442 with checkboxes. If we don't want to use buttons there, I could still adjust the checkbox style and make them look like radio buttons where applicable. But let's discuss this further at #442 if necessary. |
|
@Riksu9000 I would prefer buttons that goes to the edge. On my P8 I sometimes miss touch events on the bottom part of the screen. I noticed that in the paint application when I touch near the bottom edge, then the touch event has the coordinates with maximal value. This way it ignores the button press even it was few pixels away from the bottom edge of the button. |





I've adjusted multiple apps to better utilize the small screen. There is still more that can be done, but this is plenty for now.




The biggest change is the quick settings menu, and the rest of the changes are small, but they're important for consistency.
Also I wrote down some tips for designing UI. This could help make the UI more consistent. We might want to decide on colors and button colors in the future as well.