Skip to content

Conversation

@Riksu9000
Copy link
Contributor

I've adjusted multiple apps to better utilize the small screen. There is still more that can be done, but this is plenty for now.
The biggest change is the quick settings menu, and the rest of the changes are small, but they're important for consistency.
Also I wrote down some tips for designing UI. This could help make the UI more consistent. We might want to decide on colors and button colors in the future as well.
quicksettings
settings
apps
music

@Avamander
Copy link
Collaborator

Any chance for comparison images? :D

@Riksu9000
Copy link
Contributor Author

Here are all the changed screens right now.
Some of them, like the settings list look very similar, but I've made them use all the space all the way to the edges.

comparison

@kieranc
Copy link
Contributor

kieranc commented Jun 14, 2021

I like this, mainly because it takes me at me at least 3 tries to hit the validate firmware button each time. Would it be possible to standardise the theme/button colours between quick settings and main menu in this PR too?

@Riksu9000
Copy link
Contributor Author

Would it be possible to standardise the theme/button colours between quick settings and main menu in this PR too?

I'm not totally sure what you meant, but because of the vibration button, I don't think the base color can be turqoise in quick settings. However, when vibration is enabled, the button could be turqoise, and now we would have a standard accent color. I'll test this and post a pic soon.

@kieranc
Copy link
Contributor

kieranc commented Jun 14, 2021

Maybe the selected (vibration) button could have an outline/border instead of being a different colour, but what I meant was to have the quick settings menu look the same as the main menu in terms of the button background colour being turquoise/teal/whatever it is. It's not very important, and would maybe be better as a separate PR, since it doesn't align well with the goals of this PR. In any case, nice work.

@Riksu9000
Copy link
Contributor Author

I personally think the buttons should still be kept gray so that the enabled state really contrasts with the disabled state. And gray buttons are still used in the settings menus with the checkboxes, so it's not totally inconsistent. So maybe we shouldn't change that now. Here is the pic anyway. Maybe in the future the accent color will be selectable and this is how it would look then.

test

Also should the firmware validation buttons be made wider like in the UI guidelines I wrote, or would there be worry that the user might accidentally press the wrong one?

validation

These changes aren't committed.

@ObiKeahloa
Copy link
Contributor

I would recommend making a little space between the Validate and Reset buttons I have clicked on "Find My Device" on my mi band accidentally a few times due to there being very little space.

A little bit of space is good so that even if you click a bit off-center you don't click the other button.

@ObiKeahloa
Copy link
Contributor

Similar to the one in commit already.

@kieranc
Copy link
Contributor

kieranc commented Jun 16, 2021

I personally think the buttons should still be kept gray so that the enabled state really contrasts with the disabled state. And gray buttons are still used in the settings menus with the checkboxes, so it's not totally inconsistent. So maybe we shouldn't change that now. Here is the pic anyway. Maybe in the future the accent color will be selectable and this is how it would look then.

test

Also should the firmware validation buttons be made wider like in the UI guidelines I wrote, or would there be worry that the user might accidentally press the wrong one?

validation

These changes aren't committed.

I like the wider buttons on the firmware validator, but I think the quick settings changes should be in a separate PR.

@hubmartin
Copy link
Contributor

Works and looks fine on my P8. Exactly what I did a week ago in Music Player screen. I hated small buttons that don't go to the edge of the display. Thanks

@kieranc
Copy link
Contributor

kieranc commented Jul 23, 2021

I just tested this branch with the update_settings branch #442, they work well together and make it much easier to interact with. Nice work.

@JF002
Copy link
Collaborator

JF002 commented Jul 24, 2021

These changes look good!
@joaquimorg, what's your opinion about this PR (and maybe #442, also) ?

@joaquimorg
Copy link
Contributor

These changes look good!
@joaquimorg, what's your opinion about this PR (and maybe #442, also) ?

I like what @Riksu9000 does to improve the overall look.
The only fix i do is the quick settings buttons i think they got a little big, i guess it's to optimize the display, but i think they get too big.

As for #442, I think replacing checkboxes with buttons doesn't make much sense, we've lost track of whether it's a selection or if it's a button.

@Riksu9000
Copy link
Contributor Author

Riksu9000 commented Jul 29, 2021

The only fix i do is the quick settings buttons i think they got a little big, i guess it's to optimize the display, but i think they get too big.

Would this be better? I simply made them square so they're just a bit smaller but might look better. They appear a bit tall to me for some reason. I personally prefer what I originally proposed.
buttons

As for #442, I think replacing checkboxes with buttons doesn't make much sense, we've lost track of whether it's a selection or if it's a button.

I get your point. The reason I wanted to change it is mainly to expose the border, so it's easier to press. Also the display timeout screen would be hard to make work like in #442 with checkboxes. If we don't want to use buttons there, I could still adjust the checkbox style and make them look like radio buttons where applicable. But let's discuss this further at #442 if necessary.

@hubmartin
Copy link
Contributor

@Riksu9000 I would prefer buttons that goes to the edge. On my P8 I sometimes miss touch events on the bottom part of the screen. I noticed that in the paint application when I touch near the bottom edge, then the touch event has the coordinates with maximal value. This way it ignores the button press even it was few pixels away from the bottom edge of the button.
On smart phones I suspect there is some guess/logic which decides if I pressed near some hyperlink or button on webpage, but in the LVGL you have to press inside of the button area, which is sometimes hard on small display.
Also, thanks for all your contributions to InfiniTime, you did a lot of work there.

@Riksu9000
Copy link
Contributor Author

I decided to adjust the inner padding in applist to make it feel less cramped. Now the page indicator seems a bit close, but maybe it should be improved separately and turned into a page indicator component instead of having the code duplicated in many different screens.

padding

@Riksu9000 Riksu9000 mentioned this pull request Aug 12, 2021
@JF002 JF002 added this to the Version 1.4 milestone Aug 15, 2021
@JF002 JF002 merged commit ee44b6f into InfiniTimeOrg:develop Aug 15, 2021
@Riksu9000 Riksu9000 deleted the ui_update branch September 28, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants