Skip to content

Conversation

@NeroBurner
Copy link
Contributor

Instead of raw for loops use std::ranges::transform where possible.

And also use std::ranges::find_if instead of std::find_if.

@NeroBurner NeroBurner added this to the 1.16.0 milestone May 24, 2025
@NeroBurner NeroBurner self-assigned this May 24, 2025
@NeroBurner NeroBurner added the maintenance Background work label May 24, 2025
@NeroBurner NeroBurner force-pushed the displayapp_use_std_ranges branch 2 times, most recently from f10a5cb to 358f8b6 Compare May 24, 2025 20:08
Instead of raw for loops use `std::ranges::transform` where possible.
And also use `std::ranges::find_if` instead of `std::find_if`.
@NeroBurner NeroBurner force-pushed the displayapp_use_std_ranges branch from 358f8b6 to 294474b Compare May 29, 2025 20:35
@InfiniTimeOrg InfiniTimeOrg deleted a comment from github-actions bot May 29, 2025
@github-actions
Copy link

Build size and comparison to main:

Section Size Difference
text 375684B -160B
data 948B 0B
bss 22536B 0B

Run in InfiniEmu

@NeroBurner NeroBurner requested a review from a team May 29, 2025 20:50
Copy link
Member

@mark9064 mark9064 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know about these, but they're certainly neater. Nice that they exist!

@mark9064 mark9064 merged commit 85a0542 into main May 30, 2025
7 checks passed
@NeroBurner NeroBurner deleted the displayapp_use_std_ranges branch May 31, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Background work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants