Skip to content

Conversation

@Ghoelian
Copy link
Contributor

Fixes the PROJECT_GIT_COMMIT_HASH not getting set in Github builds.

Previously, the step that should get the short ref using git failed:

fatal: detected dubious ownership in repository at '/__w/InfiniTime/InfiniTime'
To add an exception for this directory, call:

	git config --global --add safe.directory /__w/InfiniTime/InfiniTime

The checkout action is supposed to do that already, but for some reason it's not working:

Adding repository directory to the temporary git global config as a safe directory
/usr/bin/git config --global --add safe.directory /__w/InfiniTime/InfiniTime

It looks like this is an issue more people are facing, but for some reason the issue is closed: actions/checkout#1048

The proposed fix of setting the user wasn't working, so I'm just manually adding the cloned repository as safe.

@github-actions
Copy link

github-actions bot commented Mar 29, 2025

Build size and comparison to main:

Section Size Difference
text 373120B 0B
data 948B 0B
bss 22536B 0B

Run in InfiniEmu

Copy link
Member

@mark9064 mark9064 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch :)

@mark9064 mark9064 added this to the 1.16.0 milestone May 16, 2025
@mark9064 mark9064 added the maintenance Background work label May 16, 2025
@JF002 JF002 merged commit e27e51d into InfiniTimeOrg:main May 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Background work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fatal: detected dubious ownership in repository at

3 participants