MotionService: Fix step notification on sleep #2272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
65fa72e to
b7c6717
Compare
b7c6717 to
e15961e
Compare
Send btuetooth step notifications in sleep state just like motion notifications. Rename check function from IsMotionNotificationSubscribed to IsAnyNotificationSubscribed for clarity.
e15961e to
28ae102
Compare
Member
|
Thanks for this contribution :) it all looked good but ended up being superseded by #2328 so I've closed it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using BLE notifications for motion it seams that the code enabels the sending of each motion even in sleep mode.
Using BLE notifications for steps should work the same.
I don't know how much this would use the battery, but i think it could not be more than with motion notification.
Fixes #2271