CI: Use artifact v4 instead of v3 #2224
Merged
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
mark9064
approved these changes
Jan 10, 2025
Member
mark9064
left a comment
There was a problem hiding this comment.
I've only glanced at the changes but it seems to be about functionality we don't use. Thanks!
NeroBurner
approved these changes
Jan 18, 2025
Contributor
NeroBurner
left a comment
There was a problem hiding this comment.
Wht an unfortunately named artifact 😅
Artifact infinisim-.zip successfully finalized. Artifact ID 2411680215
On topic: Changes look gold. Thanks for fixing!
Completely optional: would you like to open a similar PR for InfiniSim?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems v3 can be directly replaced by v4.
I have seen just issue with naming infinitisim artifact, which is unrelated with migration to v4. See #2223