Hrs3300: fix includes for std::begin/std::end #2128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Hrs3300 PR about Atomic HRS reads: #1845 We use `std::begin` and `std::end`, but we don't include one of the headers that define those functions. See https://en.cppreference.com/w/cpp/iterator/begin for a list of headers that define `std::begin` and `std::end`. Starting with GCC 14 this leads to a compilation error presumably because they cleaned up their headers. Fix code by inlcuding `<iterator>`
Merged
|
Build size and comparison to main:
|
mark9064
approved these changes
Sep 22, 2024
FintasticMan
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Hrs3300 PR about Atomic HRS reads:
#1845
We use
std::beginandstd::end, but we don't include one of the headers that define those functions.See https://en.cppreference.com/w/cpp/iterator/begin for a list of headers that define
std::beginandstd::end.Starting with GCC 14 this leads to a compilation error presumably because they cleaned up their headers.
Fix code by inlcuding
<iterator>