Fix MotorController::Init call order #2070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build checks have not completed. Possible reasons for this are:
|
JF002
approved these changes
Jun 2, 2024
Collaborator
JF002
left a comment
There was a problem hiding this comment.
Good catch, thank you!
I'm wondering if those calls to LoadNewScreen shouldn't go in InitHw() or in Process() to make things more tidy, but I think your fix is valid anyway :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
LoadNewScreenhere (and the one below it) callsMotorController::StopRinging()here, which in turn callsxTimerStopto stop the ringing timer. However, this timer only gets created whenDisplayApp::InitHwis called, which currently happens inDisplayApp::Processafter the initial call toLoadNewScreen. This means thatxTimerStopis called on uninitialized data, which has undefined behaviour.This PR makes it so that the call to
MotorController::Inithappens beforeLoadNewScreen.