Watch face selection using CMake #1934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build size and comparison to main:
|
The list of watch face to build into the firmware is now set by CMake (-DENABLE_WATCHFACES). Fix SettingWatchFace : convert to index to/from WatchFace when needed.
148e275 to
14d002d
Compare
Update Apps.md to mention the selection of watchfaces using Cmake.
Contributor
|
This works well for me (I rebased this locally against |
NeroBurner
requested changes
Jan 6, 2024
Contributor
NeroBurner
left a comment
There was a problem hiding this comment.
watchface to watch face, some wording and a small cmake readability improvement
Improve wording and replace "watchface" by "watch face" in Apps.md. Improve CMake readability regarding watch face selection Co-authored-by: Reinhold Gschweicher <pyro4hell@gmail.com>
Collaborator
Author
|
@vkareh Thanks for the feedback! That was exactly the goal of those changes :+1 @NeroBurner Thanks for the review, I applied all your suggestions ! |
FintasticMan
approved these changes
Jan 6, 2024
Documentation : watch faces are not system apps anymore. Co-authored-by: FintasticMan <finlay.neon.kid@gmail.com>
FintasticMan
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of watch face to build into the firmware is now set by CMake (-DENABLE_WATCHFACES).
Fix SettingWatchFace : convert to index to/from WatchFace when needed.