weather: Add some heuristics to GetCurrent* #1882
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that there is a higher likelihood that the returned event is the most up-to-date current event. It chooses the event with the lowest expiry, and between events with the same expiry, it chooses the one with the latest timestamp.
|
Build size and comparison to main:
|
Member
Author
|
Superseded by #1890. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that there is a higher likelihood that the returned event is the most up-to-date current event.
It chooses the event with the lowest expiry, and between events with the same expiry, it chooses the one with the latest timestamp.
Alternative to #1878.
I'm not the best when it comes to working with references to unique_ptrs etc, so if there's a better way to keep track of the best option so far, I'd like to hear it.