Skip to content

PTS: Add setting to display temperature in Fahrenheit #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JF002 merged 3 commits into from
Dec 23, 2023
Merged

PTS: Add setting to display temperature in Fahrenheit #1805

JF002 merged 3 commits into from
Dec 23, 2023

Conversation

@FintasticMan
Copy link
Member

@FintasticMan FintasticMan commented Jul 15, 2023 •
edited
Loading

This adds a "weather format" setting, which can be either Metric or Imperial.

Fixes #1783.

@kieranc does this look good to you?

@FintasticMan FintasticMan added enhancement Enhancement to an existing app/feature weather Bugs and PRs related to Weather labels Jul 15, 2023
@FintasticMan FintasticMan requested a review from a team July 15, 2023 01:13
@github-actions
Copy link

github-actions bot commented Jul 15, 2023 •
edited
Loading

Build size and comparison to main:

Section Size Difference
text 369544B 544B
data 940B 0B
bss 63516B 0B

@FintasticMan FintasticMan force-pushed the fahrenheit_pts branch 3 times, most recently from 539e126 to f1ef573 Compare November 16, 2023 08:45
@JF002
Copy link
Collaborator

JF002 commented Dec 21, 2023

@FintasticMan Thanks for this PR! I usually refrain from adding new settings but I think we cannot avoid this one : the world use 2 units to measure the temperature, we need to adapt :-)

Would you like to port those changes to the new Simple Weather Service implementation (#1924) ? We'll probably merge it soon.

@FintasticMan
Copy link
Member Author

FintasticMan commented Dec 21, 2023

Yes, I'll rebase this onto #1924 👍

@FintasticMan FintasticMan mentioned this pull request Dec 21, 2023
Merged
@FintasticMan FintasticMan force-pushed the fahrenheit_pts branch 2 times, most recently from 3f552ce to 6d3c77a Compare December 23, 2023 18:32
JF002
JF002 reviewed Dec 23, 2023
View reviewed changes
@FintasticMan FintasticMan force-pushed the fahrenheit_pts branch 3 times, most recently from 2711ce3 to 1b45e1f Compare December 23, 2023 18:48
JF002
JF002 reviewed Dec 23, 2023
View reviewed changes
Copy link
Collaborator

@JF002 JF002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we'll merge this one after #1924 :)

@FintasticMan FintasticMan mentioned this pull request Dec 23, 2023
Closed
@JF002 JF002 added this to the 1.14.0 milestone Dec 23, 2023
@JF002 JF002 merged commit e88d0af into InfiniTimeOrg:main Dec 23, 2023
@FintasticMan FintasticMan deleted the fahrenheit_pts branch December 23, 2023 20:43
@JF002 JF002 mentioned this pull request Dec 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JF002 JF002 JF002 left review comments

Assignees

No one assigned

Labels

enhancement Enhancement to an existing app/feature weather Bugs and PRs related to Weather

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

Weather: temp won't display in Fahrenheit

2 participants

@FintasticMan @JF002