Skip to content

Conversation

@maksalees
Copy link
Contributor

This is version of #698 with a cleaner commit history and rebased.

Previously, if the alarm was turned off, when you pressed the information button, a message was displayed that the alarm was not set. The amount of time until the alarm is now displayed as well as if it is on.
What for? Allows you to save two clicks on a button if you just need to see how much time is left before the alarm

Before

Before

After

After

Previously, if the alarm was turned off, when you pressed the information button, a message was displayed that the alarm was not set. The amount of time until the alarm is now displayed as well as if it is on.
What for? Allows you to save two clicks on a button if you just need to see how much time is left before the alarm
@maksalees maksalees force-pushed the display-time-until-alarm-even-if-is-off-2 branch from 2b3f6fc to c7897d0 Compare September 30, 2022 15:18
@NeroBurner
Copy link
Contributor

please rebase on current develop branch to fix the CI-jobs

@Riksu9000
Copy link
Contributor

In what situation would this be useful?

@maksalees
Copy link
Contributor Author

In what situation would this be useful?

For example, when choosing a time for the alarm clock, so that there is enough time to sleep. In this case you should press fewer buttons.

@maksalees
Copy link
Contributor Author

please rebase on current develop branch to fix the CI-jobs

I will rebase soon.

@github-actions
Copy link

Build size and comparison to develop:

Section Size Difference
text 414852B -32B
data 940B 0B
bss 53552B -16B

@Riksu9000
Copy link
Contributor

In what situation would this be useful?

For example, when choosing a time for the alarm clock, so that there is enough time to sleep. In this case you should press fewer buttons.

I don't see it, because if I needed to be somewhere, I'd have to set a time regardless of how much sleep I'll get. If I don't have somewhere to be, or something to do at a certain time, I wouldn't set an alarm.

@maksalees
Copy link
Contributor Author

In what situation would this be useful?

For example, when choosing a time for the alarm clock, so that there is enough time to sleep. In this case you should press fewer buttons.

I don't see it, because if I needed to be somewhere, I'd have to set a time regardless of how much sleep I'll get. If I don't have somewhere to be, or something to do at a certain time, I wouldn't set an alarm.

But it might be useful for someone.

@Riksu9000
Copy link
Contributor

But it might be useful for someone.

Sure, and I'm asking how? There hasn't been an issue about this and I'm not the only one who doesn't understand since this hasn't been merged.

@Itai-Nelken
Copy link
Contributor

I frequently use the alarm to see how much time until time X, so this feature is useful in reducing the amount of taps to see that information (set time->turn alarm on->click info button vs set time->click info button).

@Riksu9000
Copy link
Contributor

That's an interesting idea, however because it's not an intended use case, there's no guarantee it will continue to be supported in a convenient way at least. For example if we had multiple alarms and the time setting was changed in some ways. Also setting the time can take a lot of time, so the reduction probably wouldn't be very significant in comparison.

On the other hand, the current behavior may help explain the state of the alarm for someone new to using it and give them confidence that it's set correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants