-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Alarm: Display the time until alarm, even if it is off #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Alarm: Display the time until alarm, even if it is off #1346
Conversation
Previously, if the alarm was turned off, when you pressed the information button, a message was displayed that the alarm was not set. The amount of time until the alarm is now displayed as well as if it is on. What for? Allows you to save two clicks on a button if you just need to see how much time is left before the alarm
2b3f6fc to
c7897d0
Compare
|
please rebase on current |
|
In what situation would this be useful? |
For example, when choosing a time for the alarm clock, so that there is enough time to sleep. In this case you should press fewer buttons. |
I will rebase soon. |
|
Build size and comparison to develop:
|
I don't see it, because if I needed to be somewhere, I'd have to set a time regardless of how much sleep I'll get. If I don't have somewhere to be, or something to do at a certain time, I wouldn't set an alarm. |
But it might be useful for someone. |
Sure, and I'm asking how? There hasn't been an issue about this and I'm not the only one who doesn't understand since this hasn't been merged. |
|
I frequently use the alarm to see how much time until time X, so this feature is useful in reducing the amount of taps to see that information (set time->turn alarm on->click info button vs set time->click info button). |
|
That's an interesting idea, however because it's not an intended use case, there's no guarantee it will continue to be supported in a convenient way at least. For example if we had multiple alarms and the time setting was changed in some ways. Also setting the time can take a lot of time, so the reduction probably wouldn't be very significant in comparison. On the other hand, the current behavior may help explain the state of the alarm for someone new to using it and give them confidence that it's set correctly. |
This is version of #698 with a cleaner commit history and rebased.
Previously, if the alarm was turned off, when you pressed the information button, a message was displayed that the alarm was not set. The amount of time until the alarm is now displayed as well as if it is on.
What for? Allows you to save two clicks on a button if you just need to see how much time is left before the alarm
Before
After