-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Notification swap text colors #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification swap text colors #1252
Conversation
|
I think I'd prefer to keep it as it is for now to keep the contrast between the black background and according to the linked issue, this change should be good enough. |
|
@mashuptwice I've made a version with larger text & improved contrast - check Sec42@bda8431 and the zip @ https://github.com/Sec42/InfiniTime/releases/tag/1.10.0 |
|
Is there a reason to have the grey box? White text with a black background (no text bubble) would be so much better than the current implementation IMO. |
This is really good but I would prefer a smaller font, a setting for adjustable fonts would be very helpful in the future. Testing it out, I think it would be best to have a grey background, with a black text bubble with white font. That way it's a little better looking when swiping to dismiss the notification. |
|
I second what @calhix said swapping to a grey background and black text box would look a lot better. |
|
The background must be black to blend the screen edge to the thick border around the screen. |
True, how about all black like @Sec42 build but a thin white outline for the text box? I still think at the very least we should have a much darker text box (nearly black) than the current one even if contrast wise it isn't the best as its way easier to read. |
|
Outlines aren't a part of the current InfiniTime style, so I think it might look out of place. Similar gray backgrounds are used on objects like on the QuickSettings screen and the Timer. I don't see the need to change anything more with this PR. |

Improves visibility. Also reduced code duplication slightly. Fixes #972.