Skip to content

Conversation

@Riksu9000
Copy link
Contributor

Improves visibility. Also reduced code duplication slightly. Fixes #972.

InfiniSim_2022-07-27_175216

@Riksu9000 Riksu9000 added this to the 1.11.0 milestone Jul 27, 2022
@ghost
Copy link

ghost commented Jul 27, 2022

Would it be an option to use an even darker background to further increase the contrast, eg. to #202020 ?

infini_notif_color

@Riksu9000
Copy link
Contributor Author

I think I'd prefer to keep it as it is for now to keep the contrast between the black background and according to the linked issue, this change should be good enough.

@Sec42
Copy link

Sec42 commented Jul 28, 2022

@mashuptwice I've made a version with larger text & improved contrast - check Sec42@bda8431 and the zip @ https://github.com/Sec42/InfiniTime/releases/tag/1.10.0

@calhix
Copy link

calhix commented Jul 29, 2022

Is there a reason to have the grey box? White text with a black background (no text bubble) would be so much better than the current implementation IMO.

@calhix
Copy link

calhix commented Jul 29, 2022

@mashuptwice I've made a version with larger text & improved contrast - check Sec42@bda8431 and the zip @ https://github.com/Sec42/InfiniTime/releases/tag/1.10.0

This is really good but I would prefer a smaller font, a setting for adjustable fonts would be very helpful in the future. Testing it out, I think it would be best to have a grey background, with a black text bubble with white font. That way it's a little better looking when swiping to dismiss the notification.

@jakethelizard99
Copy link

I second what @calhix said swapping to a grey background and black text box would look a lot better.

@Riksu9000
Copy link
Contributor Author

The background must be black to blend the screen edge to the thick border around the screen.

@calhix
Copy link

calhix commented Jul 29, 2022

The background must be black to blend the screen edge to the thick border around the screen.

True, how about all black like @Sec42 build but a thin white outline for the text box? I still think at the very least we should have a much darker text box (nearly black) than the current one even if contrast wise it isn't the best as its way easier to read.

@Riksu9000
Copy link
Contributor Author

Outlines aren't a part of the current InfiniTime style, so I think it might look out of place. Similar gray backgrounds are used on objects like on the QuickSettings screen and the Timer. I don't see the need to change anything more with this PR.

@Riksu9000 Riksu9000 merged commit 8e72cf3 into InfiniTimeOrg:develop Aug 8, 2022
@Riksu9000 Riksu9000 deleted the notification-swap-colors branch August 8, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More readable notifications for "old eyes"

6 participants