Skip to content

Conversation

@Tiggilyboo
Copy link

@Tiggilyboo Tiggilyboo commented May 19, 2022

Hey all,

I've revamped the analogue watch face and would like to discuss what people think.
Here are some screenshots:
screenshot1
screenshot2

More detailed changes:

  • Removed rendering of background image.
  • Step meter uses lv_linemeter with 12 indicator lines (one for each hour). So for instance you have 10000 steps goal, and have walked 5000, 6 hour indicator lines will be highlighted. Once you go above the goal, the indicator lines will remain highlighting all 12.
  • Add missing icons for bluetooth and heartrate (as in Digital watchface)
  • Re-style face and hands (lovely red dot).
  • Day of week and date now render on a single line (like a lot of analogue watches out there!)

Open to discussion, like the ideas? I am fond of making the face minimal (no second indicators between the hours), and simple single lines for each hand - but obviously this is just my opinion...

- Add missing icons for bluetooth and heartrate
- Re-style face and hands (lovely red dot).
Copy link
Contributor

@Riksu9000 Riksu9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use clang-format to format the files and address the code formatting checks.

@Tiggilyboo Tiggilyboo marked this pull request as ready for review May 20, 2022 20:06
- Re-add hand trace components (thinner segments closer to center face)
@Tiggilyboo Tiggilyboo requested a review from Riksu9000 May 21, 2022 19:32
@Itai-Nelken
Copy link
Contributor

Itai-Nelken commented May 21, 2022

I like this watchface, but it's almost a completely different watchface compared to the original analog one.
I think it should be a separate watchface. Maybe it can be called SimpleAnalog as it looks simpler.

@JF002 JF002 added the new watchface This thread is about a new watchface label May 21, 2022
- Use CheckboxList from InfiniTimeOrg#1024
  for more than 4 face selections
- Clean up styles in ~WatchFaceSimpleAnalog
@Tiggilyboo Tiggilyboo changed the title Analog Face: Add stepmeter indicators around watch face, add missing icons, restyling Simple Analog Face: A simple analog face with stepmeter indicators around the watch face May 22, 2022
@Tiggilyboo
Copy link
Author

I like this watchface, but it's almost a completely different watchface compared to the original analog one. I think it should be a separate watchface. Maybe it can be called SimpleAnalog as it looks simpler.

I have implemented this face as the 5th face "Simple Analog" using the same setting method as in #1024 .As any of the other on hold faces are merged using the same settings menu, it should be easy enough to bump the index. Though I am aware that new faces are on hold whilst we sort memory usage issues?

Cheers

@yehoshuapw
Copy link
Contributor

yehoshuapw commented May 22, 2022

while it's not quite the same, part of the point (as I understood it) is to free up memory - so just adding a new analog face isn't much help.
so actually replacing the old memory heavy analog face does make sense.

once there's a better method to load faces, then the old one can be re-added.

@Tiggilyboo
Copy link
Author

while it's not quite the same, part of the point (as I understood it) is to free up memory - so just adding a new analog face isn't much help. so actually replacing the old memory heavy analog face does make sense.

once there's a better method to load faces, then the old one can be re-added.

If we do go this route, we should also remove the bg_clock.c inclusion for the old analog face background. I'm of the same opinion (replace the analog face), but not sure who decides on this, take it to a vote somehow? Otherwise, also happy to keep the PR as it stands once new faces are admitted.

@calhix
Copy link

calhix commented May 31, 2022

I'm for just replacing the current analog face with this. Why don't we have an option in the settings to remove the "smart" functions in this watch face so it's more like the current one if people prefer the style of the original?

@FintasticMan
Copy link
Member

I believe that the background image should definitely be removed, as it takes up a relatively large amount of memory. That would mean not being able to have a setting that makes it look like the old style.

@yehoshuapw
Copy link
Contributor

That would mean not being able to have a setting that makes it look like the old style.

I think what @calhix meant was to disable the step meter indicator part.

@calhix
Copy link

calhix commented Jun 1, 2022

That would mean not being able to have a setting that makes it look like the old style.

I think what @calhix meant was to disable the step meter indicator part.

This, and without the heart rate. I would prefer it never be visible on any watch face though unless you actually are checking the rate by going into the app and pushing start but that would be a separate issue.

@Riksu9000
Copy link
Contributor

I'm not sure we can justify having two very similar watch faces taking up precious memory. I'm also strongly opposed to the idea of replacing the current watch face, it's the one I've always used.

@tigercoding56
Copy link

I'm not sure we can justify having two very similar watch faces taking up precious memory. I'm also strongly opposed to the idea of replacing the current watch face, it's the one I've always used.

bg_clock.c == ~80 kb, which probably gets compressed but that is still large

@FintasticMan
Copy link
Member

I think we should definitely move the background image to the external resources. That will free up some internal flash storage, and then we can decide what to do with this watch face.

I was thinking that this could be a selectable option in the analogue watch face, like with PTS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new watchface This thread is about a new watchface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants