Github Action with docker to build the firmware #1138
Conversation
…ild docker image to build the firmware. This allows to avoid the duplication of the build logic in Docker and Github workflow format. The Dockerfile has been slightly adapted (remove the USER instructions). Docker images are now published in DockerHub (jf002/infinitime-build).
NeroBurner
left a comment
There was a problem hiding this comment.
small modernization with --platform parameter in docker readme
|
I've just created a Docker account for InfiniTime : https://hub.docker.com/repository/docker/infinitime/infinitime-build |
|
This statement is obsolete, isn't it? The image per default runs as
|
…ording to the new behavior.
@NeroBurner Yes, right! I've just fixed that. Could you have a look? |
…ve obsolete paragraph, remove redundant 'image' parameter in the command to build the docker image, use ${PWD} instead of $(pwd).
|
@NeroBurner I pushed the changes you suggested :) |
NOTE : This PR replaces #1045 (it contains many 'tentative' commits and a merge probably failed which resulted in missing commits).
The main build workflow for GitHub Actions now uses the infinitime-build docker image to build the firmware. This allows to avoid the duplication of the build logic in Docker and Github workflow format. It also ensures that the project is built exactly the same way on dev environment and on Github Actions.
The Dockerfile has been slightly adapted (remove the USER instructions). Docker images are now published in DockerHub (jf002/infinitime-build).