Apply clang-format to all files in src dir #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fad9246 to
09b852d
Compare
Riksu9000
reviewed
May 9, 2022
Avamander
requested changes
May 9, 2022
260654e to
e960830
Compare
Riksu9000
suggested changes
May 9, 2022
FintasticMan
commented
May 9, 2022
Riksu9000
approved these changes
May 9, 2022
568edd0 to
a1adf5c
Compare
a1adf5c to
d1ffb75
Compare
Collaborator
|
@Avamander Do you approve the changes applied since your last review? |
Avamander
approved these changes
May 29, 2022
|
|
||
| void HeartRateService::SubscribeNotification(uint16_t connectionHandle, uint16_t attributeHandle) { | ||
| if(attributeHandle == heartRateMeasurementHandle) | ||
| if (attributeHandle == heartRateMeasurementHandle) |
Collaborator
There was a problem hiding this comment.
We should probably add braces to these at some point, but this can be done in a separate PR at some later point
Member
Author
There was a problem hiding this comment.
Once clang-format 15 is out, that can be done automatically with the InsertBraces option.
Collaborator
|
@JF002 Yep, seems good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies clang-format to all src files except those in src/libs dir.