Skip to content

Add settings overview for digital watchface #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost wants to merge 8 commits into from
Closed

Add settings overview for digital watchface #1028

ghost wants to merge 8 commits into from

Conversation

@ghost
Copy link

@ghost ghost commented Mar 10, 2022

What does it do?

Create a settings overlay for the digital watchface to add colourful battery icon and battery percentage display. Implementation is similar to PineTime to avoid adding entries into main settings pages. Closes #582

Screenshots

PXL_20220310_225147961 MP
PXL_20220310_225156661
PXL_20220310_225207912
PXL_20220310_225213511

@ghost ghost mentioned this pull request Mar 11, 2022
Closed
@kieranc
Copy link
Contributor

kieranc commented Mar 12, 2022

I'm very happy to see this implemented, it was on my to-do list!
The settings icon doesn't seem to be quite centered on the screen, is this intentional?
It feels like there are a lot of options which could be implemented but finding space for all the settings could be complicated. BG/text color, seconds display, date format etc. I wonder if the settings buttons which appears on long press could become 2 buttons, leading to 2 pages, one for color settings and one for other options?

@NeroBurner
Copy link
Contributor

NeroBurner commented Mar 13, 2022

works great with InfiniSim

InfiniSim_2022-03-13_202335 InfiniSim_2022-03-13_202337 InfiniSim_2022-03-13_202340
InfiniSim_2022-03-13_202348 InfiniSim_2022-03-13_202352 InfiniSim_2022-03-13_202409
InfiniSim_2022-03-13_202421 InfiniSim_2022-03-13_202436

NeroBurner
NeroBurner requested changes Mar 13, 2022
View reviewed changes
Copy link
Contributor

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you've changed Settings (i.e. you added new settings). You need to increment settingsVersion

static constexpr uint32_t settingsVersion = 0x0003;

otherwise you are bound to run into the same errors as in PR #1024 (comment)

sykomaniac added 2 commits March 16, 2022 11:59
Address review comments
b248476 
- Remove extra indentation
- Fix settings icon alignment
- Increment settings version number
Merge branch 'develop' into feature/digital-settings
c55aeb3
@ghost
Copy link
Author

ghost commented Mar 16, 2022

@NeroBurner thanks for that I've incremented the settings version number
@kieranc no you are right that was an oversight and now corrected

@Avamander Avamander changed the title feat: Add settings overview for digital watchface Add settings overview for digital watchface Mar 17, 2022
@ITCactus ITCactus mentioned this pull request May 16, 2022
Merged
@Riksu9000 Riksu9000 mentioned this pull request Jul 23, 2022
Open
@ghost ghost mentioned this pull request Aug 21, 2022
Closed
@lman0
Copy link

lman0 commented Aug 21, 2022

any news @Sykomaniac ?

@ghost
Copy link
Author

ghost commented Aug 21, 2022

Happy to update the PR to the latest code base if desired

@ghost ghost closed this by deleting the head repository Jan 30, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Battery Percentage Icon

3 participants

@kieranc @NeroBurner @lman0