Skip to content

Crash when clicking on read_text_file when no file is selected #40

@Banbury

Description

@Banbury

Environment:
Windows 7
Python 3.9 (backport)

Steps to reproduce:

  • Open a new file
  • Add a read_text_file node
  • Click on the file preview

The application crashes to the desktop.

Error message:

Traceback (most recent call last):
  File "C:\Python39\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "d:\nodezator\nodezator\__main__.py", line 95, in <module>
    parse_args_and_execute_main()
  File "d:\nodezator\nodezator\__main__.py", line 89, in parse_args_and_execute_
main
    main(filepath)
  File "d:\nodezator\nodezator\__main__.py", line 56, in main
    run_app(filepath)
  File "d:\nodezator\nodezator\mainloop.py", line 209, in run_app
    raise err
  File "d:\nodezator\nodezator\mainloop.py", line 98, in run_app
    loop_holder.handle_input()
  File "d:\nodezator\nodezator\ourstdlibs\collections\general.py", line 20, in _
_call__
    item()
  File "d:\nodezator\nodezator\winman\states\loadedfile.py", line 106, in loaded
_file_event_handling
    self.loaded_file_on_mouse_release(event)
  File "d:\nodezator\nodezator\winman\states\loadedfile.py", line 506, in loaded
_file_on_mouse_release
    obj.on_mouse_release(event)
  File "d:\nodezator\nodezator\graphman\callablenode\vizop\main.py", line 87, in
 on_mouse_action
    method(event)
  File "d:\nodezator\nodezator\widget\pathpreview\base.py", line 362, in on_mous
e_release
    self.preview_paths()
  File "d:\nodezator\nodezator\widget\pathpreview\text.py", line 140, in preview
_paths
    text = path.read_text(encoding="utf-8")
  File "C:\Python39\lib\pathlib.py", line 1266, in read_text
    with self.open(mode='r', encoding=encoding, errors=errors) as f:
  File "C:\Python39\lib\pathlib.py", line 1252, in open
    return io.open(self, mode, buffering, encoding, errors, newline,
  File "C:\Python39\lib\pathlib.py", line 1120, in _opener
    return self._accessor.open(self, flags, mode)
PermissionError: [Errno 13] Permission denied: '.'

Some form of error handling would be nice. Ideally an application should never crash to the desktop.

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions