Skip to content

fix(brigadier): don't force executors by default#601

Merged
Citymonstret merged 3 commits into2.0.0-devfrom
fix/2.0.0/brig-mapping
Dec 29, 2023
Merged

fix(brigadier): don't force executors by default#601
Citymonstret merged 3 commits into2.0.0-devfrom
fix/2.0.0/brig-mapping

Conversation

@Citymonstret
Copy link
Copy Markdown
Member

@Citymonstret Citymonstret commented Dec 28, 2023

This no longer marks everything as executable, at the cost of us being able to capture invalid input.

@Citymonstret Citymonstret added this to the 2.0.0 milestone Dec 28, 2023
@Citymonstret Citymonstret force-pushed the fix/2.0.0/brig-mapping branch from 67bedcd to 9cae599 Compare December 28, 2023 16:20
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 28, 2023

Test Results

  84 files  ±0    84 suites  ±0   16s ⏱️ -6s
508 tests ±0  508 ✔️ ±0  0 💤 ±0  0 ±0 
541 runs  ±0  541 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 9831554. ± Comparison against base commit 2d4ca12.

♻️ This comment has been updated with latest results.

@Citymonstret Citymonstret force-pushed the fix/2.0.0/brig-mapping branch from 9cae599 to 558d026 Compare December 28, 2023 16:31
@Citymonstret Citymonstret marked this pull request as draft December 28, 2023 19:27
@Citymonstret Citymonstret changed the title fix: construct more accurate Brigadier commands fix(brigadier): don't force executors by default Dec 28, 2023
@Citymonstret Citymonstret force-pushed the fix/2.0.0/brig-mapping branch from 558d026 to d355b75 Compare December 28, 2023 19:40
@Citymonstret Citymonstret marked this pull request as ready for review December 28, 2023 19:41
@Citymonstret Citymonstret merged commit ffdf610 into 2.0.0-dev Dec 29, 2023
@Citymonstret Citymonstret deleted the fix/2.0.0/brig-mapping branch December 29, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants