feat(core): extract command execution from CommandManager#581
Merged
Citymonstret merged 1 commit into2.0.0-devfrom Dec 21, 2023
Merged
feat(core): extract command execution from CommandManager#581Citymonstret merged 1 commit into2.0.0-devfrom
Citymonstret merged 1 commit into2.0.0-devfrom
Conversation
48c89cc to
22feb6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically just polluting the CommandManager API. We could skip exposing the getter altogether and require the platform implementations to construct this class separately, but that feels a bit overkill.