feat: make suggestion processors act on individual suggestions#572
Merged
Citymonstret merged 14 commits into2.0.0-devfrom Dec 17, 2023
Merged
Conversation
We currently have to collect then process and then collect again, which is not ideal. By instead applying the filter when we can skip unwrapping suggestions only to immediately collect them again.
jpenilla
reviewed
Dec 17, 2023
cloud-core/src/main/java/cloud/commandframework/execution/CommandSuggestionProcessor.java
Outdated
Show resolved
Hide resolved
|
|
||
| /** | ||
| * Processes the given {@code suggestion} and returns the result. | ||
| * <p> |
Member
There was a problem hiding this comment.
We should setup checkstyle to enforce closing tags :p
cloud-core/src/main/java/cloud/commandframework/execution/CommandSuggestionProcessor.java
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/execution/CommandSuggestionProcessor.java
Outdated
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/execution/CommandSuggestionProcessor.java
Outdated
Show resolved
Hide resolved
cloud-core/src/main/java/cloud/commandframework/execution/CommandSuggestionProcessor.java
Outdated
Show resolved
Hide resolved
Base automatically changed from
2/cleanup-suggestionprovider-hierarchy
to
2.0.0-dev
December 17, 2023 19:38
…processor # Conflicts: # cloud-core/src/main/java/cloud/commandframework/arguments/LiteralParser.java # cloud-core/src/main/java/cloud/commandframework/arguments/standard/BooleanParser.java # cloud-core/src/main/java/cloud/commandframework/arguments/standard/ByteParser.java # cloud-core/src/main/java/cloud/commandframework/arguments/standard/DurationParser.java # cloud-core/src/main/java/cloud/commandframework/arguments/standard/EnumParser.java # cloud-core/src/main/java/cloud/commandframework/arguments/standard/IntegerParser.java # cloud-core/src/main/java/cloud/commandframework/arguments/standard/LongParser.java # cloud-core/src/main/java/cloud/commandframework/arguments/standard/ShortParser.java # cloud-core/src/main/java/cloud/commandframework/arguments/suggestion/SuggestionProvider.java # cloud-minecraft/cloud-brigadier/src/main/java/cloud/commandframework/brigadier/argument/WrappedBrigadierParser.java # cloud-minecraft/cloud-bukkit/src/main/java/cloud/commandframework/bukkit/parsers/EnchantmentParser.java # cloud-minecraft/cloud-bukkit/src/main/java/cloud/commandframework/bukkit/parsers/ItemStackParser.java # cloud-minecraft/cloud-bukkit/src/main/java/cloud/commandframework/bukkit/parsers/MaterialParser.java # cloud-minecraft/cloud-bukkit/src/main/java/cloud/commandframework/bukkit/parsers/NamespacedKeyParser.java # cloud-minecraft/cloud-bukkit/src/main/java/cloud/commandframework/bukkit/parsers/OfflinePlayerParser.java # cloud-minecraft/cloud-bukkit/src/main/java/cloud/commandframework/bukkit/parsers/PlayerParser.java # cloud-minecraft/cloud-bukkit/src/main/java/cloud/commandframework/bukkit/parsers/WorldParser.java # cloud-minecraft/cloud-bukkit/src/main/java/cloud/commandframework/bukkit/parsers/location/Location2DParser.java # cloud-minecraft/cloud-bukkit/src/main/java/cloud/commandframework/bukkit/parsers/location/LocationParser.java # cloud-minecraft/cloud-bungee/src/main/java/cloud/commandframework/bungee/arguments/PlayerParser.java # cloud-minecraft/cloud-fabric/src/main/java/cloud/commandframework/fabric/argument/RegistryEntryParser.java # cloud-minecraft/cloud-fabric/src/main/java/cloud/commandframework/fabric/argument/TeamParser.java # cloud-minecraft/cloud-minecraft-extras/src/main/java/cloud/commandframework/minecraft/extras/TextColorParser.java # cloud-minecraft/cloud-velocity/src/main/java/cloud/commandframework/velocity/arguments/PlayerParser.java # cloud-minecraft/cloud-velocity/src/main/java/cloud/commandframework/velocity/arguments/ServerParser.java # examples/example-bukkit/src/main/java/cloud/commandframework/examples/bukkit/builder/feature/AggregateCommandExample.java
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have to collect then process and then collect again, which is not ideal. By instead applying the filter when we can skip unwrapping suggestions only to immediately collect them again.