Skip to content

chore: List<Suggestion> -> Iterable<Suggestion>#570

Merged
Citymonstret merged 1 commit into2.0.0-devfrom
2/cleanup-suggestionprovider-hierarchy-iterable
Dec 18, 2023
Merged

chore: List<Suggestion> -> Iterable<Suggestion>#570
Citymonstret merged 1 commit into2.0.0-devfrom
2/cleanup-suggestionprovider-hierarchy-iterable

Conversation

@Citymonstret
Copy link
Copy Markdown
Member

No description provided.

@Citymonstret Citymonstret added this to the 2.0.0 milestone Dec 15, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 15, 2023

Test Results

  82 files  ±0    82 suites  ±0   16s ⏱️ -5s
496 tests ±0  496 ✔️ ±0  0 💤 ±0  0 ±0 
523 runs  ±0  523 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit f919f29. ± Comparison against base commit bdce3e6.

♻️ This comment has been updated with latest results.

@solonovamax
Copy link
Copy Markdown
Contributor

why Iterable and not Collection?

that seems more appropriate to me

@jpenilla
Copy link
Copy Markdown
Member

jpenilla commented Dec 15, 2023

Might as well change BlockingSuggestionProvider.Strings too

@Citymonstret Citymonstret force-pushed the 2/cleanup-suggestionprovider-hierarchy-iterable branch from 9d07d18 to 4254289 Compare December 15, 2023 20:08
@jpenilla
Copy link
Copy Markdown
Member

jpenilla commented Dec 16, 2023

Being able to return an Iterable/pass it to a method is more flexible than a Collection. But it's also a little more annoying to deal with on the consumer side, for example when delegating suggestions with modifications... Not sure which is a bigger consideration or if I'm missing something.

@broccolai
Copy link
Copy Markdown
Member

Would prefer Iterable

Base automatically changed from 2/cleanup-suggestionprovider-hierarchy to 2.0.0-dev December 17, 2023 19:38
@Citymonstret Citymonstret force-pushed the 2/cleanup-suggestionprovider-hierarchy-iterable branch from 4254289 to 49d8ae4 Compare December 17, 2023 20:41
@Citymonstret Citymonstret marked this pull request as ready for review December 17, 2023 20:42
@Citymonstret Citymonstret force-pushed the 2/cleanup-suggestionprovider-hierarchy-iterable branch from 49d8ae4 to f919f29 Compare December 18, 2023 08:03
@Citymonstret Citymonstret merged commit 4844a99 into 2.0.0-dev Dec 18, 2023
@Citymonstret Citymonstret deleted the 2/cleanup-suggestionprovider-hierarchy-iterable branch December 18, 2023 08:12
@Citymonstret Citymonstret mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants