Clean up SuggestionProvider hierarchy#567
Merged
Conversation
983eb40 to
ab4d2a4
Compare
Contributor
|
Any use for a static method on SuggestionProvider for some constant suggestions? Also, a thought I had was about ArgumentParser not extending SuggestionProvider anymore. It just seems like it could be better designed than having ArgumentParser extend it but having implementations implementing a subinterface of SuggestionProvider as well. What if ArgumentParser had a method that returned SuggestionParser? That way, the correct type of provider, blocking, nonblocking, strings, etc. would just be returned there instead of the overlapping interface implementations on separate types? |
cloud-core/src/main/java/cloud/commandframework/arguments/parser/ArgumentParser.java
Show resolved
Hide resolved
broccolai
approved these changes
Dec 17, 2023
Member
broccolai
left a comment
There was a problem hiding this comment.
Haven't looked through all the parsers but LGTM once BlockingSuggestionProvider is un-subclass'd
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.