Merged
Conversation
- The final `Caption` class has been turned into an interface with an immutable implementation
- The final `CaptionVariable` class has been turned into an interface with an immutable implementation
- `CaptionVariableReplacementHandler` has been turned into a generic `CaptionFormatter` which can output generic types instead of just strings
- The different classes have had their javadoc updates and the accessor prefixes are gone
- `CommandContext` and `ParserException` now have new formatting methods that take in a formatter
- The placeholder format has changed from `{placeholder}` to `<placeholder>`
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captionclass has been turned into an interface with an immutable implementationCaptionVariableclass has been turned into an interface with an immutable implementationCaptionVariableReplacementHandlerhas been turned into a genericCaptionFormatterwhich can output generic types instead of just stringsCommandContextandParserExceptionnow have new formatting methods that take in a formatter{placeholder}to<placeholder>. A lot of people pass these directly to MiniMessage so we might as well make that process a bit easier :)CaptionRegistryhas been merged with the factory delegating version, and you now register providers without specifying the caption. This means that you can catch all requests at once. Missing values will fallback onto earlier providers. There are static factory methods inCaptionProviderthat allow you to register per-faction providers.