Merged
Conversation
added 2 commits
December 6, 2023 17:26
This PR removes `CommandMeta.Key` and replaces all usage of it with `CloudKey`. It existed because of legacy reasons, and we no longer have a use for it. SimpleCommandMeta no longer has to be referenced directly, and the command meta builder has been extracted and no longer exposes the implementation. The class remains public and non-final in case anyone wants to extend it. The `CommandManager#createDefaultCommandMeta` method has a default implementation that returns an empty instance. It is very rare for the implementation of this to do anything else anyway.
This PR gets rid of SimpleCloudKey, and exposes static factory methods in CloudKey that reference an immutable implementation. CloudKey is turned into an abstract class with a final implementation of equals (and hashCode) to enforce the requirement that only the names are checked for equality. The prefixes are dropped from the CloudKey accessors.
Member
|
CloudKeyHolder#getKey could probably be renamed to cloudKey or just key |
added 5 commits
December 7, 2023 05:19
both CommandContext and CommandMeta now implement CloudKeyRegistry, which makes the API a lot more consistent. This also ensures that there are consistent overloads using strings and CloudKeyHolder.
# Conflicts: # cloud-core/src/main/java/cloud/commandframework/extra/confirmation/CommandConfirmationManager.java # cloud-core/src/main/java/cloud/commandframework/meta/CommandMeta.java # cloud-core/src/main/java/cloud/commandframework/meta/CommandMetaBuilder.java # cloud-core/src/main/java/cloud/commandframework/meta/SimpleCommandMeta.java # cloud-core/src/test/java/cloud/commandframework/CommandBeanTest.java # cloud-core/src/test/java/cloud/commandframework/CommandPermissionTest.java # cloud-core/src/test/java/cloud/commandframework/CommandTreeTest.java # cloud-minecraft/cloud-bukkit/src/main/java/cloud/commandframework/bukkit/BukkitCommandMeta.java # cloud-minecraft/cloud-fabric/src/main/java/cloud/commandframework/fabric/FabricServerCommandManager.java # cloud-minecraft/cloud-sponge7/src/main/java/cloud/commandframework/sponge7/SpongeMetaKeys.java # examples/example-bukkit/src/main/java/cloud/commandframework/examples/bukkit/feature/ProcessorExample.java
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gets rid of SimpleCloudKey, and exposes static factory methods in CloudKey that reference an immutable implementation.
CloudKey is turned into an abstract class with a final implementation of equals (and hashCode) to enforce the requirement that only the names are checked for equality.
The prefixes are dropped from the CloudKey accessors.