Merged
Conversation
A command description is a pair of argument descriptions (a short description and a verbose description). This uses argument descriptions as they are already well-supported by the platforms. This means that Minecraft commands can use the rich descriptions and all the features that come with that. The old meta keys have been removed. A separate PR will address the `@CommandDescription` annotation. This should solve #527.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A command description is a pair of argument descriptions (a short description and a verbose description).
This uses argument descriptions as they are already well-supported by the platforms. This means that Minecraft commands can use the rich descriptions and all the features that come with that.
The old meta keys have been removed. A separate PR will address the
@CommandDescriptionannotation.This also changes how Bukkit attempts to resolve descriptions for root commands. It will:
BUKKIT_DESCRIPTIONcommand meta key.CommandManager.commandBuilder(...)).This should solve #527. The mapping to Bukkit is less than perfect, as Bukkit's help menu displays root commands, and root commands are not really a concept in Cloud outside of the command tree.