chore(cloud-brigadier): refactor the code#525
Merged
Citymonstret merged 14 commits into2.0.0-devfrom Dec 1, 2023
Merged
Conversation
added 8 commits
November 26, 2023 14:51
Aggregate parsers is a more flexible version of the compound parser.
It was becoming impossible to follow what is happening in CloudBrigadierManager and there was a lot of repeated code. This refactoring does not change any functionality.
Base automatically changed from
feature/2.0.0/aggregate-parsers
to
2.0.0-dev
November 29, 2023 06:15
added 4 commits
November 29, 2023 07:17
# Conflicts: # cloud-minecraft/cloud-brigadier/src/main/java/cloud/commandframework/brigadier/CloudBrigadierManager.java
# Conflicts: # cloud-minecraft/cloud-brigadier/src/main/java/cloud/commandframework/brigadier/CloudBrigadierManager.java # cloud-minecraft/cloud-paper/src/main/java/cloud/commandframework/paper/PaperBrigadierListener.java
added 2 commits
December 1, 2023 09:37
02dc9e6 to
4daf239
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was becoming impossible to follow what is happening in CloudBrigadierManager and there was a lot of repeated code. This refactoring does not change any functionality.
This depends on #522, and will be marked as ready once that has been merged into 2.0.0-dev.