Skip to content

feature: make parsing & suggestions return futures#521

Merged
Citymonstret merged 7 commits into2.0.0-devfrom
feature/2.0.0/future-parsing
Nov 22, 2023
Merged

feature: make parsing & suggestions return futures#521
Citymonstret merged 7 commits into2.0.0-devfrom
feature/2.0.0/future-parsing

Conversation

@Citymonstret
Copy link
Copy Markdown
Member

@Citymonstret Citymonstret commented Nov 20, 2023

No description provided.

@Citymonstret Citymonstret added this to the 2.0.0 milestone Nov 20, 2023
@Citymonstret Citymonstret self-assigned this Nov 20, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 20, 2023

Test Results

  68 files  +  1    68 suites  +1   13s ⏱️ -5s
443 tests +  5  443 ✔️ +  5  0 💤 ±0  0 ±0 
455 runs  +14  455 ✔️ +14  0 💤 ±0  0 ±0 

Results for commit 45531da. ± Comparison against base commit 324bb89.

♻️ This comment has been updated with latest results.

@Citymonstret
Copy link
Copy Markdown
Member Author

Citymonstret commented Nov 20, 2023

note to self: https://github.com/jhalterman/concurrentunit is cool and can also be used to test command methods by invoking the waiter from the command handler.

@Citymonstret Citymonstret force-pushed the feature/2.0.0/future-parsing branch from b8086f3 to 45531da Compare November 22, 2023 09:54
@Citymonstret Citymonstret linked an issue Nov 22, 2023 that may be closed by this pull request
@Citymonstret Citymonstret marked this pull request as ready for review November 22, 2023 10:06
@Citymonstret Citymonstret merged commit 2a425f4 into 2.0.0-dev Nov 22, 2023
@Citymonstret Citymonstret deleted the feature/2.0.0/future-parsing branch November 22, 2023 10:06
@Citymonstret Citymonstret mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Suspending suggestions

1 participant