Skip to content

feature: allow for dynamic default values#505

Merged
Citymonstret merged 4 commits into2.0.0-devfrom
feature/2.0.0/defaults
Nov 16, 2023
Merged

feature: allow for dynamic default values#505
Citymonstret merged 4 commits into2.0.0-devfrom
feature/2.0.0/defaults

Conversation

@Citymonstret
Copy link
Copy Markdown
Member

Implements #500.

@Citymonstret Citymonstret added this to the 2.0.0 milestone Nov 15, 2023
@Citymonstret Citymonstret self-assigned this Nov 15, 2023
@Citymonstret Citymonstret linked an issue Nov 15, 2023 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 15, 2023

Test Results

  57 files  +1    57 suites  +1   9s ⏱️ -4s
241 tests +3  241 ✔️ +3  0 💤 ±0  0 ±0 
242 runs  +3  242 ✔️ +3  0 💤 ±0  0 ±0 

Results for commit cee29fb. ± Comparison against base commit 4ca84ad.

♻️ This comment has been updated with latest results.

@masmc05
Copy link
Copy Markdown
Contributor

masmc05 commented Nov 15, 2023

can this also fix #455 ?

@Citymonstret
Copy link
Copy Markdown
Member Author

can this also fix #455 ?

I think this would get fixed automatically as of #498 rather than this PR, as it'd append to the input, spaces and all. With this PR you now have the option of supplying a location object as well if you're using builders. Either way, it should be resolved in 2.0.

@Citymonstret Citymonstret marked this pull request as ready for review November 15, 2023 14:34
@Citymonstret Citymonstret merged commit c89a44a into 2.0.0-dev Nov 16, 2023
@Citymonstret Citymonstret deleted the feature/2.0.0/defaults branch November 16, 2023 09:15
@Citymonstret Citymonstret mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Make default values more powerful

2 participants