Skip to content

feature(annotations): allow for more @Suggestions method types#496

Merged
Citymonstret merged 1 commit into2.0.0-devfrom
feature/2.0.0/suggestion-methods-relaxing
Nov 13, 2023
Merged

feature(annotations): allow for more @Suggestions method types#496
Citymonstret merged 1 commit into2.0.0-devfrom
feature/2.0.0/suggestion-methods-relaxing

Conversation

@Citymonstret
Copy link
Copy Markdown
Member

We can allow the suggestion methods to be more flexible with no real harm to the suggestion provider. This lets the methods return any collection types/a stream containing either suggestions, or strings that will get converted into simple suggestions.

We can allow the suggestion methods to be more flexible with no real harm to the suggestion provider. This lets the methods return any collection types/a stream containing either suggestions, or strings that will get converted into simple suggestions.
@Citymonstret Citymonstret added this to the 2.0.0 milestone Nov 12, 2023
@github-actions
Copy link
Copy Markdown

Test Results

  54 files  +1    54 suites  +1   8s ⏱️ -3s
235 tests +4  235 ✔️ +4  0 💤 ±0  0 ±0 
236 runs  +4  236 ✔️ +4  0 💤 ±0  0 ±0 

Results for commit 7775ff0. ± Comparison against base commit 148bd37.

@Citymonstret Citymonstret changed the title feature(annotations): allow for more @Suggestions methods feature(annotations): allow for more @Suggestions method types Nov 12, 2023
@Citymonstret Citymonstret merged commit b0e6277 into 2.0.0-dev Nov 13, 2023
@Citymonstret Citymonstret deleted the feature/2.0.0/suggestion-methods-relaxing branch November 13, 2023 07:18
@Citymonstret Citymonstret self-assigned this Nov 14, 2023
@Citymonstret Citymonstret mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant