feature: prepare for complex suggestions#490
Merged
Citymonstret merged 1 commit into2.0.0-devfrom Nov 12, 2023
Merged
Conversation
0c56049 to
d558338
Compare
This PR prepares for more complex suggestions by replacing the string suggestions with an interface. The default parsers can still supply string suggestions, but they'll be wrapped in `Suggestion#simple`. The idea is that there can be another suggestion implementation that offers tooltip support, etc.
d558338 to
674c5fc
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares for more complex suggestions by replacing the string suggestions with an interface. The default parsers can still supply string suggestions, but they'll be wrapped in
Suggestion#simple.The idea is that there can be another suggestion implementation that offers tooltip support, etc.