fix: Thumbnail fallback and multiple thumbnail using dicom tag browser#340
Merged
igoroctaviano merged 2 commits intomasterfrom Oct 10, 2025
Merged
fix: Thumbnail fallback and multiple thumbnail using dicom tag browser#340igoroctaviano merged 2 commits intomasterfrom
igoroctaviano merged 2 commits intomasterfrom
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fix: Duplicate Thumbnail Images in DICOM Tag Browser
Problem
Thumbnail scale was wrong
After commit 89a62a4, thumbnail images were appearing twice in the DICOM tag browser.
Root Cause
When thumbnail image support was added:
thumbnailImagesand
volumeImagesarrays (since they share ImageType VOLUME/THUMBNAIL behavior)Solution
Remove
thumbnailImagesfrom the Slide constructor concatenation.THUMBNAIL images are already included in
volumeImagessince they:Changes
Result
Thumbnail images now appear only once in the DICOM tag browser while
maintaining their proper relationship with the volume image pyramid.
Ref: #337 (comment)