@igoroctaviano FYI: It's impossible to satisfy all of the DeepSource requirements

My first commit had "this.handleVisibilityChange.bind(this)" and it said I shouldn't have .bind because it would be recalculated on every re-render

Then I changed it to (checked: boolean) => this.handleVisibilityChange(checked), and it said I shouldn't have a arrow function because of the same problem.

Finally, I used the constructor to bind the handleVisibilityChange function on the instantiation of the object, but now it's complaining that I shouldn't use "this.handleVisibilityChange" without binding it. So it's impossible to satisfy all of its requirements

@pedrokohler cau take a look at deep source check?

cau take a look at deep source check?

@igoroctaviano have you seen my previous comment?

@pedrokohler have you tried:

class AnnotationGroupList extends React.Component<
AnnotationGroupListProps,
unknown
> {
  handleVisibilityChange = (checked: boolean): void => {
    if (checked) {
      this.props.annotationGroups.forEach((annotationGroup) => {
        this.props.onAnnotationGroupVisibilityChange({
          annotationGroupUID: annotationGroup.uid,
          isVisible: checked
        })
      })
      return
    }

    this.props.visibleAnnotationGroupUIDs.forEach((annotationGroupUID) => {
      this.props.onAnnotationGroupVisibilityChange({
        annotationGroupUID,
        isVisible: checked
      })
    })
  }

This does not require a constructor or bind, and it does not create an arrow function all the time, since it's a class assignment.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@igoroctaviano everything is passing now.